From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Paul A Jungwirth <pj@illuminatedcomputing.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Jeff Davis <pgsql@j-davis.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: David Fetter <david@fetter.org>
Subject: Re: range_agg
Date: Fri, 20 Mar 2020 11:48:12 -0300
Message-ID: <20200320144812.GA12308@alvherre.pgsql> (raw)
In-Reply-To: <CA+renyW+F+8ojN-gN4Y0Pu_2gWHg3WdjRxpQGk=pWEheQ+3thg@mail.gmail.com>
On 2020-Mar-14, Paul A Jungwirth wrote:
> On Fri, Mar 13, 2020 at 2:39 PM Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> > Here's the rebased version.
> >
> > I just realized I didn't include the API change I proposed in
> > https://postgr.es/m/20200306200343.GA625@alvherre.pgsql ...
>
> Thanks for your help with this Alvaro!
>
> I was just adding your changes to my own branch and I noticed your
> v12-0001 has different parameter names here:
>
> static MultirangeIOData *
> -get_multirange_io_data(FunctionCallInfo fcinfo, Oid mltrngtypid,
> IOFuncSelector func)
> +get_multirange_io_data(FunctionCallInfo fcinfo, Oid rngtypid,
> IOFuncSelector func)
> I'm pretty sure mltrngtypid is the correct name here. Right? Let me
> know if I'm missing something. :-)
Heh. The intention here was to abbreviate to "typid", but if you want
to keep the longer name, it's OK too. I don't think that name is
particularly critical, since it should be obvious that it must be a
multirange type.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, pj@illuminatedcomputing.com, tgl@sss.pgh.pa.us, pgsql@j-davis.com, pavel.stehule@gmail.com, david@fetter.org
Subject: Re: range_agg
In-Reply-To: <20200320144812.GA12308@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox