pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Justin Pryzby <pryzby@telsasoft.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers@postgresql.org
Subject: Re: error context for vacuum to include block number
Date: Sat, 21 Mar 2020 03:03:19 -0500
Message-ID: <20200321080319.GF13662@telsasoft.com> (raw)
In-Reply-To: <CAA4eK1+iuT4gqiqYVdLkOggjA9q5v+dVxT_G3dOyHVokn+YjBg@mail.gmail.com>
References: <CAA4eK1KuP+fznRUJ_x_hcbWzPLS-vCJfZn9wjxWK-+TO1Luzbg@mail.gmail.com>
	<20200319040758.GP26184@telsasoft.com>
	<CAA4eK1LwDGPmAvtOmmHvDTp-KHvcKCW7u36sFKdHjrWJaSVE2w@mail.gmail.com>
	<20200319202931.GT26184@telsasoft.com>
	<20200320002909.GU26184@telsasoft.com>
	<CAA4eK1L_FWiqqBfpm_C8b8bw95EykonbcLWzFFQAC6ucgudZFQ@mail.gmail.com>
	<20200320065120.GW26184@telsasoft.com>
	<CAA4eK1+TQi4qanvLCOdcMbRKb=nCsJkWPhDi+KmOnkOyi79_Sw@mail.gmail.com>
	<20200320145359.GY26184@telsasoft.com>
	<CAA4eK1+iuT4gqiqYVdLkOggjA9q5v+dVxT_G3dOyHVokn+YjBg@mail.gmail.com>

On Sat, Mar 21, 2020 at 01:00:03PM +0530, Amit Kapila wrote:
> I have addressed your comments in the attached patch.  Today, while
> testing error messages from various phases, I noticed that the patch
> fails to display error context if the error occurs during the truncate
> phase.  The reason was that we had popped the error stack in
> lazy_scan_heap due to which it never calls the callback.  I think we
> need to set up callback at a higher level as is done in the attached
> patch.  I have done the testing by inducing errors in various phases
> and it prints the required information.  Let me know what you think of
> the attached?

Thanks.  My tests with TRUNCATE were probably back when we had multiple
push/pop cycles of local error callbacks.

This passes my tests.

-- 
Justin





view thread (139+ messages)  latest in thread

Message-ID: <20200321080319.GF13662@telsasoft.com>
Permalink:  ../20200321080319.GF13662@telsasoft.com/
Also on:    postgresql.org/message-id/20200321080319.GF13662@telsasoft.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pryzby@telsasoft.com, amit.kapila16@gmail.com, masahiko.sawada@2ndquadrant.com, alvherre@2ndquadrant.com, andres@anarazel.de, michael@paquier.xyz
  Subject: Re: error context for vacuum to include block number
  In-Reply-To: <20200321080319.GF13662@telsasoft.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox