agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Justin Pryzby <pryzby@telsasoft.com>
To: Alexey Kondratov <a.kondratov@postgrespro.ru>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>
Cc: Steve Singer <steve@ssinger.info>
Cc: pgsql-hackers@lists.postgresql.org, Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Alexander Korotkov <a.korotkov@postgrespro.ru>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Jose Luis Tallon <jltallon@adv-solutions.net>
Subject: Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly
Date: Thu, 26 Mar 2020 23:01:06 -0500
Message-ID: <20200327040106.GC20103@telsasoft.com> (raw)
In-Reply-To: <20200326180112.GH17431@telsasoft.com>
References: <20191202082134.GI1696@paquier.xyz>
<c8ed43871e171ca2077aa9e1d0ed970a@postgrespro.ru>
<20200211164848.GO1412@telsasoft.com>
<eb4cdddc0d6197f3fef15d36758c93fe@postgrespro.ru>
<20200229145304.GI29456@telsasoft.com>
<20200309200447.GA32459@telsasoft.com>
<cb874a90-3946-91e4-4c31-5075f425b280@postgrespro.ru>
<20200325234027.GH21443@telsasoft.com>
<39a055a7a8cd19552f35f4cb98a8cd80@postgrespro.ru>
<20200326180112.GH17431@telsasoft.com>
> Another issue is this:
> > +VACUUM ( FULL [, ...] ) [ TABLESPACE <replaceable class="parameter">new_tablespace</replaceable> ] [ <replaceable class="parameter">table_and_columns</replaceable> [, ...] ]
> As you mentioned in your v1 patch, in the other cases, "tablespace
> [tablespace]" is added at the end of the command rather than in the middle. I
> wasn't able to make that work, maybe because "tablespace" isn't a fully
> reserved word (?). I didn't try with "SET TABLESPACE", although I understand
> it'd be better without "SET".
I think we should use the parenthesized syntax for vacuum - it seems clear in
hindsight.
Possibly REINDEX should use that, too, instead of adding OptTablespace at the
end. I'm not sure.
CLUSTER doesn't support parenthesized syntax, but .. maybe it should?
Also, perhaps VAC FULL (and CLUSTER, if it grows parenthesized syntax), should
support something like this:
USING INDEX TABLESPACE name
I guess I would prefer just "index tablespace", without "using":
|VACUUM(FULL, TABLESPACE ts, INDEX TABLESPACE its) t;
|CLUSTER(VERBOSE, TABLESPACE ts, INDEX TABLESPACE its) t;
--
Justin
view thread (154+ messages) latest in thread
Message-ID: <20200327040106.GC20103@telsasoft.com>
Permalink: ../20200327040106.GC20103@telsasoft.com/
Also on: postgresql.org/message-id/20200327040106.GC20103@telsasoft.com
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, a.kondratov@postgrespro.ru, michael@paquier.xyz, masahiko.sawada@2ndquadrant.com, steve@ssinger.info, alvherre@2ndquadrant.com, robertmhaas@gmail.com, a.korotkov@postgrespro.ru, sawada.mshk@gmail.com, jltallon@adv-solutions.net
Subject: Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly
In-Reply-To: <20200327040106.GC20103@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox