From: Justin Pryzby <pryzby@telsasoft.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: error context for vacuum to include block number
Date: Mon, 30 Mar 2020 22:23:08 -0500
Message-ID: <20200331032307.GD14618@telsasoft.com> (raw)
In-Reply-To: <CAA4eK1KLncZB5xLrxqESbVnM3ovzPX+BSOQyTcRtZFzqOW0LGg@mail.gmail.com>
References: <20200326221752.GR17431@telsasoft.com>
<20200326224951.GA20085@alvherre.pgsql>
<20200326233321.GA15224@telsasoft.com>
<CAA4eK1LLSGHgyOdRApxuJdMvXMChoCPHMqWetnUTEK0bPpjM1g@mail.gmail.com>
<20200330162616.GP20103@telsasoft.com>
<CAA4eK1KLncZB5xLrxqESbVnM3ovzPX+BSOQyTcRtZFzqOW0LGg@mail.gmail.com>
On Tue, Mar 31, 2020 at 07:50:45AM +0530, Amit Kapila wrote:
> On Mon, Mar 30, 2020 at 9:56 PM Justin Pryzby <pryzby@telsasoft.com> wrote:
> >
> > On Mon, Mar 30, 2020 at 02:31:53PM +0530, Amit Kapila wrote:
> > > The v37-0003-Avoid-some-calls-to-RelationGetRelationName.patch looks
> > > good to me. I have added the commit message in the patch.
> >
> > I realized the 0003 patch has an error in lazy_vacuum_index; it should be:
> >
> > - RelationGetRelationName(indrel),
> > + vacrelstats->indname,
> >
>
> Hmm, it is like that in the patch I have sent yesterday. Are you
> referring to the patch I have sent yesterday or some older version?
Oh good. That was a recent fix I made, and I was afraid I'd never sent it, and
not sure if you'd used it. Looks like it was fixed since v36... As you can
see, I'm losing track of my branches. It will be nice to finally put this to
rest.
> One thing I have noticed is that there is some saving by using
> vacrelstats->relnamespace as that avoids sys cache lookup. OTOH,
> using vacrelstats->relname doesn't save much, but maybe for the sake
> of consistency, we can use it.
Mostly I wrote that to avoid repeatedly calling functions/macro with long name.
I consider it a minor cleanup. I think we should put them to use. The
LVRelStats describes them as not being specifically for the error context.
--
Justin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, amit.kapila16@gmail.com, alvherre@2ndquadrant.com, masahiko.sawada@2ndquadrant.com, andres@anarazel.de, michael@paquier.xyz
Subject: Re: error context for vacuum to include block number
In-Reply-To: <20200331032307.GD14618@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox