pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Justin Pryzby <pryzby@telsasoft.com>
To: Jürgen Purtz <juergen@purtz.de>
Cc: Corey Huinker <corey.huinker@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Roger Harkavy <rogerharkavy@gmail.com>
Cc: pgsql-hackers@postgresql.org, Fabien COELHO <coelho@cri.ensmp.fr>
Cc: Michael Paquier <michael@paquier.xyz>
Subject: Re: Add A Glossary
Date: Tue, 31 Mar 2020 12:58:45 -0500
Message-ID: <20200331175845.GF14618@telsasoft.com> (raw)
In-Reply-To: <84cfa166-89d2-db0c-f5bd-421ca2b2f590@purtz.de>
References: <CADkLM=fwtE-TCU7sRnvaE74z12kOp_A+CdUwMr7aZt39pXbh6A@mail.gmail.com>
	<20200320001122.GA19602@alvherre.pgsql>
	<20200320195841.GA13662@telsasoft.com>
	<64b49f34-eaf6-6de2-e951-0eb8d4afabc2@purtz.de>
	<20200327201200.GV20103@telsasoft.com>
	<ff6028d0-ff04-6d11-c41b-2bddb41777d0@purtz.de>
	<CADkLM=eHCVmL8JnmaW2h+XXLRpKzkLrq6WXMbKB7giJCuS=jXA@mail.gmail.com>
	<84cfa166-89d2-db0c-f5bd-421ca2b2f590@purtz.de>

On Tue, Mar 31, 2020 at 04:13:00PM +0200, Jürgen Purtz wrote:
> Please find some minor suggestions in the attachment. They are based on
> Corey's last patch 0001-glossary-v4.patch.

> @@ -220,7 +220,7 @@
>        Record</glossterm>s to the file system and creates a special
>        checkpoint record. This process is initiated when predefined
>        conditions are met, such as a specified amount of time has passed, or
> -      a certain volume of records have been collected.
> +      a certain volume of records has been collected.

I think you're correct in that "volume" is singular.  But I think "collected"
is the wrong world.  I suggested "written".

>       <para>
> -      One of the <acronym>ACID</acronym> properties. This means that concurrently running 
> +      One of the <acronym>ACID</acronym> properties. This means that concurrently running

These could maybe say "required" or "essential" >ACID< properties

>       <para>
> +      In reference to a <glossterm>Table</glossterm>:
>        A <glossterm>Table</glossterm> that can be queried directly,

Maybe: "In reference to a >Relation<: A table which can be queried directly,"

>        table in the collection.
>       </para>
>       <para>
> -      When referring to an <glossterm>Analytic</glossterm>
> -      <glossterm>Function</glossterm>: a partition is a definition
> -      that identifies which neighboring
> +      In reference to a <glossterm>Analytic Function</glossterm>:
s/a/an/

> @@ -1333,7 +1334,8 @@
>      <glossdef>
>       <para>
>        The condition of having no duplicate values in the same
> -      <glossterm>Relation</glossterm>. Often used in the concept of
> +      <glossterm>Column</glossterm> of a <glossterm>Relation</glossterm>.
> +      Often used in the concept of

s/concept/context/, but  I said that before, so maybe it was rejected.

-- 
Justin





view thread (97+ messages)  latest in thread

Message-ID: <20200331175845.GF14618@telsasoft.com>
Permalink:  ../20200331175845.GF14618@telsasoft.com/
Also on:    postgresql.org/message-id/20200331175845.GF14618@telsasoft.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pryzby@telsasoft.com, juergen@purtz.de, corey.huinker@gmail.com, alvherre@2ndquadrant.com, rogerharkavy@gmail.com, coelho@cri.ensmp.fr, michael@paquier.xyz
  Subject: Re: Add A Glossary
  In-Reply-To: <20200331175845.GF14618@telsasoft.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox