From: Justin Pryzby <pryzby@telsasoft.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Julien Rouhaud <rjuju123@gmail.com>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Kirill Bychik <kirill.bychik@gmail.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Subject: Re: User Interface for WAL usage data
Date: Thu, 2 Apr 2020 00:41:20 -0500
Message-ID: <20200402054120.GC14618@telsasoft.com> (raw)
In-Reply-To: <CAA4eK1+o1Vj4Rso09pKOaKhY8QWTA0gWwCL3TGCi1rCLBBf-QQ@mail.gmail.com>
References: <CAA4eK1+o1Vj4Rso09pKOaKhY8QWTA0gWwCL3TGCi1rCLBBf-QQ@mail.gmail.com>
On Thu, Apr 02, 2020 at 10:13:18AM +0530, Amit Kapila wrote:
> In thread [1], we are discussing to expose WAL usage data for each
> statement in a way quite similar to how we expose BufferUsage data.
> The way it exposes seems reasonable to me and no one else raises any
> objection. It could be that it appears fine to others who have
> reviewed the patch but I thought it would be a good idea to write a
> separate email just for its UI and see if anybody has objection.
+1
Regarding v10-0004-Add-option-to-report-WAL-usage-in-EXPLAIN-and-au.patch:
I think there should be additional spaces before "full" and before "bytes":
> WAL: records=2359 full page records=42 bytes=447788
Compare with these:
"Sort Method: %s %s: %ldkB\n",
"Buckets: %d (originally %d) Batches: %d (originally %d) Memory Usage: %ldkB\n",
"Buckets: %d Batches: %d Memory Usage: %ldkB\n",
Otherwise "records=2359 full page records=42" is hard to parse.
> Exposed via auto_explain
> WAL: records=200 full page records=2 bytes=37387
Same
In v10-0002:
+ * BufferUsage and WalUsage during executing maintenance command can be
should say "during execution of a maintenance command".
I'm afraid that'll cause merge conflicts for you :(
In 0003:
+ /* Provide WAL update data to the instrumentation */
Remove "data" ??
--
Justin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, amit.kapila16@gmail.com, pgsql-hackers@lists.postgresql.org, rjuju123@gmail.com, dilipbalaut@gmail.com, kirill.bychik@gmail.com, masao.fujii@oss.nttdata.com
Subject: Re: User Interface for WAL usage data
In-Reply-To: <20200402054120.GC14618@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox