From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: James Coleman <jtc331@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Rafia Sabih <rafia.pghackers@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: Simon Riggs <simon@2ndquadrant.com>
Cc: Shaun Thomas <shaun.thomas@2ndquadrant.com>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: Alexander Korotkov <a.korotkov@postgrespro.ru>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Cc: Andreas Karlsson <andreas@proxel.se>
Subject: Re: [PATCH] Incremental sort (was: PoC: Partial sort)
Date: Mon, 6 Apr 2020 21:57:22 +0200
Message-ID: <20200406195722.teiha6foiy3lix3s@development> (raw)
In-Reply-To: <20200405130110.2bdxaz4ed5jx2eae@development>
References: <CAAaqYe99B9cRLU+FWJudNx-6O4TgnWYCrRtsv2NcUs4TzG5qrw@mail.gmail.com>
<CAAaqYe953TA0Pj+08jEBgK_=5zMCJO-vgYnh4n_Me71ZdzDJLg@mail.gmail.com>
<20200401214215.ut6b72e3zlbm33w2@development>
<CAAaqYe8fWa8pBUStzW-4JocF+d3pFBVLFmb9rtcD0m12NskBJw@mail.gmail.com>
<20200402024746.5wlwk6q7eiv5faux@development>
<CAAaqYe90h3F5NbgtNJAMrXAiGZwML8=_E_qs4MCyYtqea+5Hhg@mail.gmail.com>
<20200403002028.kp3rxncmwvsui6xz@development>
<CAAaqYe--jV9pHrX5NRw9R2QGG+nRuPPKguzHhKZwhp6XPOiyuQ@mail.gmail.com>
<CAAaqYe9XO7ZKrpVkrz2e0ja=eeFCX0Wqpmc7r23R84JU9uCLxQ@mail.gmail.com>
<20200405130110.2bdxaz4ed5jx2eae@development>
Hi,
I've pushed the fist part of this patch series - I've reorganized it a
bit by moving the add_partial_path changes to the end. That way I've
been able to add regression test demonstrating impact of the change on
plans involving incremental sort nodes (which wouldn't be possible when
committing the add_partial_path first). I'll wait a bit before pushing
the two additional parts, so that if something fails we know which bit
caused it.
I've been running extensive benchmarks with the aim to detect any
regressions caused by this patch, particularly during planning. Attached
is the script I've used and spreadsheet with results. The numbers show
throughput with different queries (SELECT, EXPLANN and joins) with the
patches committed one by one. There's quite a bit of noise, even though
the script pins processes to cores and restricts CPU frequency. Overall,
I don't see any obvious regression - the numbers are generally within
0.5% of the master, and the behavior is the same even with -M prepared
which should not be subject to any planner overhead. I do have results
from another machine (2-socket Xeon) but the results are much more
noisy, although the general conclusions are about the same.
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachments:
[application/vnd.oasis.opendocument.spreadsheet] results-join-v54-i5.ods (96.1K, ../20200406195722.teiha6foiy3lix3s@development/2-results-join-v54-i5.ods)
download
[application/x-sh] run-pgbench.sh (3.7K, ../20200406195722.teiha6foiy3lix3s@development/3-run-pgbench.sh)
download
[application/x-sh] run-benchmark.sh (436B, ../20200406195722.teiha6foiy3lix3s@development/4-run-benchmark.sh)
download
[text/csv] results-join-v54-i5.csv (83.2K, ../20200406195722.teiha6foiy3lix3s@development/5-results-join-v54-i5.csv)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tomas.vondra@2ndquadrant.com, jtc331@gmail.com, tgl@sss.pgh.pa.us, alvherre@2ndquadrant.com, michael@paquier.xyz, rafia.pghackers@gmail.com, pg@bowt.ie, simon@2ndquadrant.com, shaun.thomas@2ndquadrant.com, 9erthalion6@gmail.com, a.korotkov@postgrespro.ru, pgsql-hackers@lists.postgresql.org, andreas@proxel.se
Subject: Re: [PATCH] Incremental sort (was: PoC: Partial sort)
In-Reply-To: <20200406195722.teiha6foiy3lix3s@development>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox