From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: James Coleman <jtc331@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Rafia Sabih <rafia.pghackers@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: Simon Riggs <simon@2ndquadrant.com>
Cc: Shaun Thomas <shaun.thomas@2ndquadrant.com>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: Alexander Korotkov <a.korotkov@postgrespro.ru>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Cc: Andreas Karlsson <andreas@proxel.se>
Subject: Re: [PATCH] Incremental sort (was: PoC: Partial sort)
Date: Mon, 6 Apr 2020 23:12:32 +0200
Message-ID: <20200406211232.35s2gmygrfx3ljrj@development> (raw)
In-Reply-To: <20200406205438.GA30063@alvherre.pgsql>
References: <19920.1586206115@sss.pgh.pa.us>
<20200406205438.GA30063@alvherre.pgsql>
On Mon, Apr 06, 2020 at 04:54:38PM -0400, Alvaro Herrera wrote:
>On 2020-Apr-06, Tom Lane wrote:
>
>> Locally, things pass without force_parallel_mode, but turning it on
>> produces failures that look similar to rhinoceros's (didn't examine
>> other BF members).
>
>FWIW I looked at the eight failures there were about fifteen minutes ago
>and they were all identical. I can confirm that, in my laptop, the
>tests work without that GUC, and fail in exactly that way with it.
>
Yes, there's a thinko in show_incremental_sort_info() and it returns too
soon. I'll push a fix in a minute.
thanks
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tomas.vondra@2ndquadrant.com, alvherre@2ndquadrant.com, tgl@sss.pgh.pa.us, jtc331@gmail.com, michael@paquier.xyz, rafia.pghackers@gmail.com, pg@bowt.ie, simon@2ndquadrant.com, shaun.thomas@2ndquadrant.com, 9erthalion6@gmail.com, a.korotkov@postgrespro.ru, pgsql-hackers@lists.postgresql.org, andreas@proxel.se
Subject: Re: [PATCH] Incremental sort (was: PoC: Partial sort)
In-Reply-To: <20200406211232.35s2gmygrfx3ljrj@development>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox