agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: Surafel Temesgen <surafel3000@gmail.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: FETCH FIRST clause WITH TIES option
Date: Tue, 7 Apr 2020 23:25:57 -0400
Message-ID: <20200408032557.GA29002@alvherre.pgsql> (raw)
In-Reply-To: <87a73mn4cl.fsf@news-spur.riddles.org.uk>
On 2020-Apr-08, Andrew Gierth wrote:
> >>>>> "Alvaro" == Alvaro Herrera <alvherre@2ndquadrant.com> writes:
>
> Alvaro> It turns out that the SQL standard is much more limited in what
> Alvaro> it will accept there. But our grammar (what we'll accept for
> Alvaro> the ancient LIMIT clause) is very lenient -- it'll take just
> Alvaro> any expression. I thought about reducing that to NumericOnly
> Alvaro> for FETCH FIRST .. WITH TIES, but then I have to pick: 1)
> Alvaro> gram.y fails to compile because of a reduce/reduce conflict, or
> Alvaro> 2) also restricting FETCH FIRST .. ONLY to NumericOnly. Neither
> Alvaro> of those seemed very palatable.
>
> FETCH FIRST ... ONLY was made _too_ restrictive initially, such that it
> didn't allow parameters (which are allowed by the spec); see 1da162e1f.
Hmm, oh, I see.
> (That change didn't present a problem for ruleutils, because FETCH FIRST
> ... ONLY is output as a LIMIT clause instead.)
Right, I noticed that and kept it unchanged.
> This needs to be fixed in ruleutils, IMO, not by changing what the
> grammar accepts.
Fair. I didn't change what the grammar accepts. I ended up only
throwing an error in parse analysis when a bare NULL const is seen.
I guess we could fix ruleutils to add parens when NULL is seen, but
I'm not sure it's necessary or useful. (LIMIT uses a null to represent
the LIMIT ALL case.)
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
view thread (61+ messages) latest in thread
Message-ID: <20200408032557.GA29002@alvherre.pgsql>
Permalink: ../20200408032557.GA29002@alvherre.pgsql/
Also on: postgresql.org/message-id/20200408032557.GA29002@alvherre.pgsql
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, andrew@tao11.riddles.org.uk, surafel3000@gmail.com, tomas.vondra@2ndquadrant.com
Subject: Re: FETCH FIRST clause WITH TIES option
In-Reply-To: <20200408032557.GA29002@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox