pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Bruce Momjian <bruce@momjian.us>
To: Alexander Korotkov <a.korotkov@postgrespro.ru>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: PG 13 release notes, first draft
Date: Mon, 11 May 2020 09:20:35 -0400
Message-ID: <20200511132035.GA3888@momjian.us> (raw)
In-Reply-To: <CAPpHfduAyDgP=0TXcCQOsuQ4Lx+KsckJoMKny4obJE6DDS-BaA@mail.gmail.com>
References: <20200505031600.GB21752@momjian.us>
	<CAPpHfdu7gvvxChxLQ-=02JgJLyeDV5TzLxrXR+ujO6O2L1YexQ@mail.gmail.com>
	<20200506234652.GD3649@momjian.us>
	<CAPpHfduAyDgP=0TXcCQOsuQ4Lx+KsckJoMKny4obJE6DDS-BaA@mail.gmail.com>

On Thu, May  7, 2020 at 08:12:30PM +0300, Alexander Korotkov wrote:
> On Thu, May 7, 2020 at 2:46 AM Bruce Momjian <bruce@momjian.us> wrote:
> >         <para>
> >         Allow CREATE INDEX to specify the GiST signature length and maximum number of integer ranges (Nikita Glukhov)
> >         </para>
> 
> Should we specify which particular opclasses are affected?  Or at
> least mention it affects core and particular contribs?

Sorry for the delay in replying.  Yes, I agree we should list all of
those operator class cases where we now take arguments.  I looked at the
patch but got confused and missed the doc changes that clearly need to
be in the release notes.  I see these operator classes now taking
parameters, as you helpfully listed in your commit message:

	tsvector_ops
	gist_ltree_ops
	gist__ltree_ops
	gist_trgm_ops
	gist_hstore_ops
	gist__int_ops
	gist__intbig_ops

I assume the double-underscore is because the first underscore is to
separate words, and the second one is for the array designation, right?

So my big question is whether people will understand when they are using
these operator classes, since many of them are defaults.  Can you use an
operator class parameter when you are just using the default operator
class and not specifying its name?  What I thinking  that just saying
the operator class take arguments might not be helpful.  I think I see
enough detail in the documentation to write release note items for
these, but I will have to point out they need to specify the operator
class, even if it is the default, right?

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +





view thread (194+ messages)  latest in thread

Message-ID: <20200511132035.GA3888@momjian.us>
Permalink:  ../20200511132035.GA3888@momjian.us/
Also on:    postgresql.org/message-id/20200511132035.GA3888@momjian.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: bruce@momjian.us, a.korotkov@postgrespro.ru
  Subject: Re: PG 13 release notes, first draft
  In-Reply-To: <20200511132035.GA3888@momjian.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox