From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: new heapcheck contrib module
Date: Thu, 14 May 2020 15:31:40 -0400
Message-ID: <20200514193140.GA19814@alvherre.pgsql> (raw)
In-Reply-To: <CA+TgmoaLUS27N0Ye5pcb7-GQuib3Ds_ZzM1qckgNjp6aSjWgvA@mail.gmail.com>
On 2020-May-14, Robert Haas wrote:
> I have a question about what you mean here by "arbitrarily."
>
> If you mean that we shouldn't have the buildfarm run the proposed heap
> corruption checker against heap pages full of randomly-generated
> garbage, I tend to agree. Such a test wouldn't be very stable and
> might fail in lots of low-probability ways that could require
> unreasonable effort to find and fix.
This is what I meant. I was thinking of blocks generated randomly.
> If you mean that we shouldn't have the buildfarm run the proposed heap
> corruption checker against any corrupted heap pages at all, I tend to
> disagree.
Yeah, IMV those would not be arbitrarily corrupted -- instead they're
crafted to be corrupted in some specific way.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, robertmhaas@gmail.com, pg@bowt.ie, mark.dilger@enterprisedb.com, andres@anarazel.de
Subject: Re: new heapcheck contrib module
In-Reply-To: <20200514193140.GA19814@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox