From: Michael Paquier <michael@paquier.xyz>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Atomic operations within spinlocks
Date: Thu, 4 Jun 2020 16:03:28 +0900
Message-ID: <20200604070328.GS89559@paquier.xyz> (raw)
In-Reply-To: <CA+hUKGL6hxNv=DJkeZQ2mvPCAX5JLE+xn2EhWpPxL8KK3aWKsQ@mail.gmail.com>
References: <1141819.1591208385@sss.pgh.pa.us>
<20200603204542.reuladbmgmjqzoi6@alap3.anarazel.de>
<CA+hUKGL6hxNv=DJkeZQ2mvPCAX5JLE+xn2EhWpPxL8KK3aWKsQ@mail.gmail.com>
On Thu, Jun 04, 2020 at 09:40:31AM +1200, Thomas Munro wrote:
> Yeah. It'd be fine to move that after the spinlock release. Although
> it's really just for informational purposes only, not for any data
> integrity purpose, reading it before the spinlock acquisition would
> theoretically allow it to appear to be (reportedly) behind
> flushedUpto, which would be silly.
Indeed. This could just be done after the spinlock section. Sorry
about that.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, thomas.munro@gmail.com, andres@anarazel.de, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
Subject: Re: Atomic operations within spinlocks
In-Reply-To: <20200604070328.GS89559@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox