From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Andres Freund <andres@anarazel.de>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: sitnikov.vladimir@gmail.com, PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: SIGSEGV from START_REPLICATION 0/XXXXXXX in XLogSendPhysical () at walsender.c:2762
Date: Thu, 4 Jun 2020 19:46:00 -0400
Message-ID: <20200604234600.GA10763@alvherre.pgsql> (raw)
In-Reply-To: <20200604225108.optmmc3ndiggej32@alap3.anarazel.de>
On 2020-Jun-04, Andres Freund wrote:
> postgres[52656][1]=# SELECT 1;
> ┌──────────┐
> │ ?column? │
> ├──────────┤
> │ 1 │
> └──────────┘
> (1 row)
>
>
> I am very much not in love with the way that was implemented, but it's
> there, and it's used as far as I know (cf tablesync.c).
Ouch ... so they made IDENT in the replication grammar be a trigger to
enter the regular grammar. Crazy. No way to put those worms back in
the tin now, I guess.
It is still my opinion that we should prohibit a logical replication
connection from being used to do physical replication. Horiguchi-san,
Sawada-san and Masao-san are all of the same opinion. Dave Cramer (of
the JDBC team) is not opposed to the change -- he says they're just
using it because they didn't realize they should be doing differently.
Both Michael P. and you are saying we shouldn't break it because it
works today, but there isn't a real use-case for it.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, andres@anarazel.de, michael@paquier.xyz, masao.fujii@oss.nttdata.com, masahiko.sawada@2ndquadrant.com, horikyota.ntt@gmail.com
Subject: Re: SIGSEGV from START_REPLICATION 0/XXXXXXX in XLogSendPhysical () at walsender.c:2762
In-Reply-To: <20200604234600.GA10763@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox