From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: masao.fujii@oss.nttdata.com
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Review for GetWALAvailability()
Date: Fri, 26 Jun 2020 20:46:10 -0400
Message-ID: <20200627004610.GA7754@alvherre.pgsql> (raw)
In-Reply-To: <20200625.172803.429475667684022055.horikyota.ntt@gmail.com>
On 2020-Jun-25, Kyotaro Horiguchi wrote:
> It is error-prone restriction, as discussed before.
>
> Without changing updator-side, invalid restart_lsn AND valid
> invalidated_at can be regarded as the lost state. With the following
> change suggested by Fujii-san we can avoid the confusing status.
>
> With attached first patch on top of the slot-dirtify fix below, we get
> "lost" for invalidated slots after restart.
Makes sense. I pushed this change, thanks.
> The confusing status can be avoided without fixing it, but I prefer to
> fix it. As Fujii-san suggested upthread, couldn't we remember
> lastRemovedSegNo in the contorl file? (Yeah, it cuases a bump of
> PG_CONTROL_VERSION and CATALOG_VERSION_NO?).
I think that's a pg14 change. Feel free to submit a patch to the
commitfest.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, horikyota.ntt@gmail.com, masao.fujii@oss.nttdata.com
Subject: Re: Review for GetWALAvailability()
In-Reply-To: <20200627004610.GA7754@alvherre.pgsql>
References: <20200625.172803.429475667684022055.horikyota.ntt@gmail.com> <20200627004610.GA7754@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox