From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: new heapcheck contrib module
Date: Tue, 30 Jun 2020 14:44:44 -0400
Message-ID: <20200630184444.GA15974@alvherre.pgsql> (raw)
In-Reply-To: <5CC85F28-F210-47AC-8DA8-EC4E82AF3FD5@enterprisedb.com>
I think there are two very large patches here. One adds checking of
heapam tables to amcheck, and the other adds a binary that eases calling
amcheck from the command line. I think these should be two separate
patches.
I don't know what to think of a module contrib/pg_amcheck. I kinda lean
towards fitting it in src/bin/scripts rather than as a contrib module.
However, it seems a bit weird that it depends on a contrib module.
Maybe amcheck should not be a contrib module at all but rather a new
extension in src/extensions/ that is compiled and installed (in the
filesystem, not in databases) by default.
I strongly agree with hardening backend code so that all the crashes
that Mark has found can be repaired. (We discussed this topic
before[1]: we'd repair all crashes when run with production code, not
all assertion crashes.)
[1] https://postgr.es/m/20200513221051.GA26592@alvherre.pgsql
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, mark.dilger@enterprisedb.com, dilipbalaut@gmail.com, robertmhaas@gmail.com, pg@bowt.ie, andres@anarazel.de
Subject: Re: new heapcheck contrib module
In-Reply-To: <20200630184444.GA15974@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox