From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Bruce Momjian <bruce@momjian.us>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: David Rowley <dgrowleyml@gmail.com>
Cc: Jeff Davis <pgsql@j-davis.com>
Cc: Melanie Plageman <melanieplageman@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Default setting for enable_hashagg_disk (hash_mem)
Date: Fri, 3 Jul 2020 15:50:02 -0400
Message-ID: <20200703195002.GA28095@alvherre.pgsql> (raw)
In-Reply-To: <20200703140808.GE26235@momjian.us>
On 2020-Jul-03, Bruce Momjian wrote:
> Well, the bottom line is that we are designing features during beta.
Well, we're designing a way for users to interact the new feature.
The feature itself is already in, and it works well in general terms. I
expect that the new behavior is a win in the majority of cases, and the
problem being discussed here will only manifest as a regression in
corner cases. (I don't have data to back this up, but if this weren't
the case we would have realized much earlier).
It seem to me we're designing a solution to a problem that was found
during testing, which seems perfectly acceptable to me. I don't see
grounds for reverting the behavior and I haven't seen anyone suggesting
that it would be an appropriate solution to the issue.
> If we add a new behavior to PG 13, we then have the pre-PG 13 behavior,
> the pre-patch behavior, and the post-patch behavior. How are people
> supposed to test all of that?
They don't have to. We tell them that we added some new tweak for a new
pg13 feature in beta3 and that's it.
> Add to that that some don't even feel we
> need a new behavior, which is delaying any patch from being applied.
If we don't need any new behavior, then we would just close the open
item and call the current state good, no?
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, bruce@momjian.us, pg@bowt.ie, pryzby@telsasoft.com, tomas.vondra@2ndquadrant.com, robertmhaas@gmail.com, andres@anarazel.de, dgrowleyml@gmail.com, pgsql@j-davis.com, melanieplageman@gmail.com
Subject: Re: Default setting for enable_hashagg_disk (hash_mem)
In-Reply-To: <20200703195002.GA28095@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox