From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: masao.fujii@oss.nttdata.com
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: min_safe_lsn column in pg_replication_slots view
Date: Wed, 8 Jul 2020 19:07:57 -0400
Message-ID: <20200708230757.GA28114@alvherre.pgsql> (raw)
In-Reply-To: <1724648.1594230917@sss.pgh.pa.us>
On 2020-Jul-08, Tom Lane wrote:
> Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> > In absence of other suggestions I gave this the name XLogMBVarToSegs,
> > and redefined ConvertToXSegs to use that. Didn't touch callers in
> > xlog.c to avoid pointless churn. Pushed to both master and 13.
>
> The buildfarm's sparc64 members seem unhappy with this.
Hmm. Some of them are, yeah, but it's not universal. For example
mussurana and ibisbill are not showing failures.
Anyway the error is pretty strange: only GetWALAvailability is showing a
problem, but the size calculation in the view function def is returning
a negative number, as expected.
So looking at the code in GetWALAvailability, what happens is that
targetSeg >= oldestSlotSeg, but we expect the opposite. I'd bet for
targetSeg to be correct, since its input is just the slot LSN -- pretty
easy. But for oldestSlotSeg, we have KeepLogSeg involved.
No immediate ideas ...
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, tgl@sss.pgh.pa.us, horikyota.ntt@gmail.com, masao.fujii@oss.nttdata.com, pgsql-hackers@lists.postgresql.org
Subject: Re: min_safe_lsn column in pg_replication_slots view
In-Reply-To: <20200708230757.GA28114@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox