From: Michael Paquier <michael@paquier.xyz>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Log the location field before any backtrace
Date: Fri, 10 Jul 2020 11:04:28 +0900
Message-ID: <20200710020324.GI11153@paquier.xyz> (raw)
In-Reply-To: <20200709163138.GA23549@alvherre.pgsql>
References: <C8394FF2-0E6D-49D0-8DEE-6155AA8D7065@yesql.se>
<20200709163138.GA23549@alvherre.pgsql>
On Thu, Jul 09, 2020 at 12:31:38PM -0400, Alvaro Herrera wrote:
> On 2020-Jul-09, Daniel Gustafsson wrote:
>> On 9 Jul 2020, at 11:17, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
>>>
>>> In PG13, we added the ability to add backtraces to the log
>>> output. After some practical experience with it, I think the
>>> order in which the BACKTRACE and the LOCATION fields are printed
>>> is wrong. I propose we put the LOCATION field before the
>>> BACKTRACE field, not after. This makes more sense because the
>>> location is effectively at the lowest level of the backtrace.
>>
>> Makes sense, +1
>
> Likewise
+1.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, alvherre@2ndquadrant.com, daniel@yesql.se, peter.eisentraut@2ndquadrant.com
Subject: Re: Log the location field before any backtrace
In-Reply-To: <20200710020324.GI11153@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox