From: Michael Paquier <michael@paquier.xyz>
To: movead.li@highgo.ca <movead.li@highgo.ca>
Cc: petr <petr@2ndquadrant.com>
Cc: simon <simon@2ndquadrant.com>
Cc: Madan Kumar <madankumar1993@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@lists.postgresql.org>
Cc: craig <craig@2ndquadrant.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: andres <andres@anarazel.de>
Cc: soumyadeep2007 <soumyadeep2007@gmail.com>
Subject: Re: A patch for get origin from commit_ts.
Date: Sun, 12 Jul 2020 21:42:26 +0900
Message-ID: <20200712124226.GE21680@paquier.xyz> (raw)
In-Reply-To: <20200710010606.GE11153@paquier.xyz>
References: <20200706003635.GC2143@paquier.xyz>
<202007061112287118394@highgo.ca>
<20200706080136.GH2143@paquier.xyz>
<2020070710022545488010@highgo.ca>
<20200707053548.GA3605@paquier.xyz>
<2020070809312199165531@highgo.ca>
<20200708015124.GB18003@paquier.xyz>
<2020070810112594002139@highgo.ca>
<20200708060824.GC18003@paquier.xyz>
<20200710010606.GE11153@paquier.xyz>
On Fri, Jul 10, 2020 at 10:06:06AM +0900, Michael Paquier wrote:
> Please note that I have switched the patch as ready for committer. So
> I'll try to get that done, with roident as attribute name. If
> somebody prefers a different name or has an objection, please feel
> free to chime in.
Hearing nothing, committed after fixing few things:
- The docs reversed <parameter> and <type>.
- The comment on top of GetLatestCommitTsData() mentioned "extra"
instead of "nodeid". Not an issue of this patch but I have just fixed
it.
- We could just have used memset for nulls when the data could not be
found in pg_xact_commit_timestamp_origin().
- Added some casts to Oid for the new ObjectIdGetDatum() calls.
- Changed the tests to not show numerical values for roident, checking
instead that the values are non-zero for the cases where we don't
expect a valid replication origin. For the valid cases, I have just
used a join with pg_replication_origin to grab roname. This makes the
tests more portable.
After applying the patch as of b1e48bb, longfin has also complained
that regression tests should prefix replication origins with
"regress_". This has been fixed with ea3e15d.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: michael@paquier.xyz, movead.li@highgo.ca, petr@2ndquadrant.com, simon@2ndquadrant.com, madankumar1993@gmail.com, pgsql-hackers@lists.postgresql.org, craig@2ndquadrant.com, alvherre@2ndquadrant.com, andres@anarazel.de, soumyadeep2007@gmail.com
Subject: Re: A patch for get origin from commit_ts.
In-Reply-To: <20200712124226.GE21680@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox