pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feedEncoding of src/timezone/tznames/Europe.txt
7+ messages / 3 participants
[nested] [flat]
Commits from this thread:
2020-07-17 7fe3083f4c a220e345c8 a40733d047 85c4297a79 38bd976c10 39064225a6 ca5588acc3 Ensure that distributed timezone abbreviation files are plain ASCII.
* Encoding of src/timezone/tznames/Europe.txt
@ 2020-07-16 10:07 Christoph Berg <myon@debian.org>
0 siblings, 1 reply; 7+ messages in thread
From: Christoph Berg @ 2020-07-16 10:07 UTC (permalink / raw)
To: pgsql-hackers
Is there any reason why src/timezone/tznames/Europe.txt is encoded in
latin1 and not utf-8?
The offending lines are these timezones:
MESZ 7200 D # Mitteleuropäische Sommerzeit (German)
# (attested in IANA comments though not their code)
MEZ 3600 # Mitteleuropäische Zeit (German)
# (attested in IANA comments though not their code)
It's not important for anything, just general sanity. (Spotted by
Debian's package checker, lintian.)
Christoph
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Encoding of src/timezone/tznames/Europe.txt
@ 2020-07-16 14:24 Tom Lane <tgl@sss.pgh.pa.us>
parent: Christoph Berg <myon@debian.org>
0 siblings, 1 reply; 7+ messages in thread
From: Tom Lane @ 2020-07-16 14:24 UTC (permalink / raw)
To: Christoph Berg <myon@debian.org>; +Cc: pgsql-hackers
Christoph Berg <myon@debian.org> writes:
> Is there any reason why src/timezone/tznames/Europe.txt is encoded in
> latin1 and not utf-8?
> The offending lines are these timezones:
> MESZ 7200 D # Mitteleuropäische Sommerzeit (German)
> # (attested in IANA comments though not their code)
> MEZ 3600 # Mitteleuropäische Zeit (German)
> # (attested in IANA comments though not their code)
> It's not important for anything, just general sanity. (Spotted by
> Debian's package checker, lintian.)
Hm. TBH, my first reaction is "let's lose the accents". I agree that
it's not great to be installing files that are encoded in latin1, but
it might not be great to be installing files that are encoded in utf8
either. Aren't we better off insisting that these files be plain ascii?
I notice that the copies of these lines in src/timezone/tznames/Default
seem to be ascii-ified already. Haven't traced the git history,
but I bet somebody fixed Default without noticing the other copy.
regards, tom lane
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Encoding of src/timezone/tznames/Europe.txt
@ 2020-07-16 19:46 Christoph Berg <myon@debian.org>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 7+ messages in thread
From: Christoph Berg @ 2020-07-16 19:46 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-hackers
Re: Tom Lane
> > MESZ 7200 D # Mitteleuropäische Sommerzeit (German)
> > # (attested in IANA comments though not their code)
>
> > It's not important for anything, just general sanity. (Spotted by
> > Debian's package checker, lintian.)
>
> Hm. TBH, my first reaction is "let's lose the accents".
Or that, yes. (The correct German transliteration is
"Mitteleuropaeische" with 'ae'.)
Christoph
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Encoding of src/timezone/tznames/Europe.txt
@ 2020-07-17 01:16 Michael Paquier <michael@paquier.xyz>
parent: Christoph Berg <myon@debian.org>
0 siblings, 1 reply; 7+ messages in thread
From: Michael Paquier @ 2020-07-17 01:16 UTC (permalink / raw)
To: Christoph Berg <myon@debian.org>; Tom Lane <tgl@sss.pgh.pa.us>; pgsql-hackers
On Thu, Jul 16, 2020 at 09:46:03PM +0200, Christoph Berg wrote:
> Or that, yes. (The correct German transliteration is
> "Mitteleuropaeische" with 'ae'.)
tznames/Europe.txt is iso-latin-1-unix for buffer-file-coding-system
since its introduction in d8b5c95, and tznames/Default is using ASCII
as well since this point. +1 to switch all that to ASCII and give up
on the accents.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Encoding of src/timezone/tznames/Europe.txt
@ 2020-07-17 15:06 Tom Lane <tgl@sss.pgh.pa.us>
parent: Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 7+ messages in thread
From: Tom Lane @ 2020-07-17 15:06 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: Christoph Berg <myon@debian.org>; pgsql-hackers
Michael Paquier <michael@paquier.xyz> writes:
> On Thu, Jul 16, 2020 at 09:46:03PM +0200, Christoph Berg wrote:
>> Or that, yes. (The correct German transliteration is
>> "Mitteleuropaeische" with 'ae'.)
> tznames/Europe.txt is iso-latin-1-unix for buffer-file-coding-system
> since its introduction in d8b5c95, and tznames/Default is using ASCII
> as well since this point. +1 to switch all that to ASCII and give up
> on the accents.
Done that way. I also checked for other discrepancies between
tznames/Default and the other files, and found a few more trivialities.
regards, tom lane
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Encoding of src/timezone/tznames/Europe.txt
@ 2020-07-17 17:24 Christoph Berg <myon@debian.org>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 7+ messages in thread
From: Christoph Berg @ 2020-07-17 17:24 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Michael Paquier <michael@paquier.xyz>; pgsql-hackers
Re: Tom Lane
> Done that way. I also checked for other discrepancies between
> tznames/Default and the other files, and found a few more trivialities.
Thanks!
Christoph
^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: Encoding of src/timezone/tznames/Europe.txt
@ 2020-07-18 01:40 Michael Paquier <michael@paquier.xyz>
parent: Christoph Berg <myon@debian.org>
0 siblings, 0 replies; 7+ messages in thread
From: Michael Paquier @ 2020-07-18 01:40 UTC (permalink / raw)
To: Christoph Berg <myon@debian.org>; Tom Lane <tgl@sss.pgh.pa.us>; pgsql-hackers
On Fri, Jul 17, 2020 at 07:24:28PM +0200, Christoph Berg wrote:
> Re: Tom Lane
>> Done that way. I also checked for other discrepancies between
>> tznames/Default and the other files, and found a few more trivialities.
>
> Thanks!
+1.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2020-07-18 01:40 UTC | newest]
Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2020-07-16 10:07 Encoding of src/timezone/tznames/Europe.txt Christoph Berg <myon@debian.org>
2020-07-16 14:24 ` Tom Lane <tgl@sss.pgh.pa.us>
2020-07-16 19:46 ` Christoph Berg <myon@debian.org>
2020-07-17 01:16 ` Michael Paquier <michael@paquier.xyz>
2020-07-17 15:06 ` Tom Lane <tgl@sss.pgh.pa.us>
2020-07-17 17:24 ` Christoph Berg <myon@debian.org>
2020-07-18 01:40 ` Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox