pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Christoph Berg <myon@debian.org>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Encoding of src/timezone/tznames/Europe.txt
Date: Thu, 16 Jul 2020 10:24:29 -0400
Message-ID: <3356880.1594909469@sss.pgh.pa.us> (raw)
In-Reply-To: <20200716100743.GE3534683@msg.df7cb.de>
References: <20200716100743.GE3534683@msg.df7cb.de>

Christoph Berg <myon@debian.org> writes:
> Is there any reason why src/timezone/tznames/Europe.txt is encoded in
> latin1 and not utf-8?

> The offending lines are these timezones:

> MESZ     7200 D  # Mitteleuropäische Sommerzeit (German)
>                  #     (attested in IANA comments though not their code)

> MEZ      3600    # Mitteleuropäische Zeit (German)
>                  #     (attested in IANA comments though not their code)

> It's not important for anything, just general sanity. (Spotted by
> Debian's package checker, lintian.)

Hm.  TBH, my first reaction is "let's lose the accents".  I agree that
it's not great to be installing files that are encoded in latin1, but
it might not be great to be installing files that are encoded in utf8
either.  Aren't we better off insisting that these files be plain ascii?

I notice that the copies of these lines in src/timezone/tznames/Default
seem to be ascii-ified already.  Haven't traced the git history,
but I bet somebody fixed Default without noticing the other copy.

			regards, tom lane





view thread (7+ messages)  latest in thread

Message-ID: <3356880.1594909469@sss.pgh.pa.us>
Permalink:  ../3356880.1594909469@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/3356880.1594909469@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, myon@debian.org
  Subject: Re: Encoding of src/timezone/tznames/Europe.txt
  In-Reply-To: <3356880.1594909469@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox