pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Dmitry Dolgov <9erthalion6@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: David Steele <david@pgmasters.net>
Cc: Nikita Glukhov <n.gluhov@postgrespro.ru>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: David Fetter <david@fetter.org>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: Oleksandr Shulgin <oleksandr.shulgin@zalando.de>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: Oleg Bartunov <obartunov@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: [HACKERS] [PATCH] Generic type subscripting
Date: Sat, 1 Aug 2020 16:33:34 +0200
Message-ID: <20200801143334.d7d3tsb7gaezx6vq@localhost> (raw)
In-Reply-To: <1808585.1596224122@sss.pgh.pa.us>
References: <CAFj8pRDQwPD2v+2E+jg+ttDKr5k2o=OAw-bLd5Asj5ds28_YTQ@mail.gmail.com>
	<10957.1584899227@sss.pgh.pa.us>
	<CAFj8pRAHcASw+XP44tf8H5vk+oRud1mNhF8XYwaOYAeY32+XZQ@mail.gmail.com>
	<23946.1584906094@sss.pgh.pa.us>
	<CAFj8pRCcP2R67j=T60E+gRNf8aiv_L9m7JTnn5N7ptAscyY26Q@mail.gmail.com>
	<20200516122802.g4qbfxkr2zr7nlv2@localhost>
	<20200719191016.GW23581@telsasoft.com>
	<20200720160216.lav6vmyv6wbg7bfl@localhost>
	<20200728134308.qsstgwyyx3ngsfcw@localhost>
	<1808585.1596224122@sss.pgh.pa.us>

> On Fri, Jul 31, 2020 at 03:35:22PM -0400, Tom Lane wrote:
>
> I started to look through this again, and really found myself wondering
> why we're going to all this work to invent what are fundamentally pretty
> bogus "features".  The thing that particularly sticks in my craw is the
> 0005 patch, which tries to interpret a subscript of a JSON value as either
> integer or text depending on, seemingly, the phase of the moon.  I don't
> think that will work.  For example, with existing arrays you can do
> something like arraycol['42'] and the unknown-type literal is properly
> cast to an integer.  The corresponding situation with a JSON subscript
> would have no principled resolution.
>
> It doesn't help any that both coercion alternatives are attempted at
> COERCION_ASSIGNMENT level, which makes it noticeably more likely that
> they'll both succeed.  But using ASSIGNMENT level is quite inappropriate
> in any context where it's not 100% certain what the intended type is.
>
> The proposed commit message for 0005 claims that this is somehow improving
> our standards compliance, but I see nothing in the SQL spec suggesting
> that you can subscript a JSON value at all within the SQL language, so
> I think that claim is just false.

It's due to my lack of writing skills. As far as I can remember the
discussion was about JSON path part of the standard, where one allowed
to use float indexes with implementation-defined rounding or truncation.
In this patch series I'm trying to think of JSON subscript as an
equivalent for JSON path, hence this misleading description. Having said
that, I guess the main motivation behind 0005 is performance
improvements. Hopefully Nikita can provide more insights. Overall back
when 0005 patch was suggested its implementation looked reasonable for
me, but I'll review it again.

> Maybe this could be salvaged by flushing 0005 in its current form and
> having the jsonb subscript executor do something like "if the current
> value-to-be-subscripted is a JSON array, then try to convert the textual
> subscript value to an integer".  Not sure about what the error handling
> rules ought to be like, though.

I'm fine with the idea of separating 0005 patch and potentially prusuing
it as an independent item. Just need to rebase 0006, since Pavel
mentioned that it's a reasonable change he would like to see in the
final result.





view thread (276+ messages)  latest in thread

Message-ID: <20200801143334.d7d3tsb7gaezx6vq@localhost>
Permalink:  ../20200801143334.d7d3tsb7gaezx6vq@localhost/
Also on:    postgresql.org/message-id/20200801143334.d7d3tsb7gaezx6vq@localhost

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: 9erthalion6@gmail.com, tgl@sss.pgh.pa.us, pryzby@telsasoft.com, pavel.stehule@gmail.com, david@pgmasters.net, n.gluhov@postgrespro.ru, alvherre@2ndquadrant.com, david@fetter.org, thomas.munro@gmail.com, thomas.munro@enterprisedb.com, oleksandr.shulgin@zalando.de, robertmhaas@gmail.com, andres@anarazel.de, michael.paquier@gmail.com, obartunov@gmail.com, peter.eisentraut@2ndquadrant.com
  Subject: Re: [HACKERS] [PATCH] Generic type subscripting
  In-Reply-To: <20200801143334.d7d3tsb7gaezx6vq@localhost>
  References: <CAFj8pRDQwPD2v+2E+jg+ttDKr5k2o=OAw-bLd5Asj5ds28_YTQ@mail.gmail.com> <10957.1584899227@sss.pgh.pa.us> <CAFj8pRAHcASw+XP44tf8H5vk+oRud1mNhF8XYwaOYAeY32+XZQ@mail.gmail.com> <23946.1584906094@sss.pgh.pa.us> <CAFj8pRCcP2R67j=T60E+gRNf8aiv_L9m7JTnn5N7ptAscyY26Q@mail.gmail.com> <20200516122802.g4qbfxkr2zr7nlv2@localhost> <20200719191016.GW23581@telsasoft.com> <20200720160216.lav6vmyv6wbg7bfl@localhost> <20200728134308.qsstgwyyx3ngsfcw@localhost> <1808585.1596224122@sss.pgh.pa.us> <20200801143334.d7d3tsb7gaezx6vq@localhost>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox