pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Cc: ashutosh.bapat@2ndquadrant.com, Noah Misch <noah@leadboat.com>
Subject: Re: walsender waiting_for_ping spuriously set
Date: Fri, 7 Aug 2020 19:18:29 -0400
Message-ID: <20200807231829.GA3040@alvherre.pgsql> (raw)
In-Reply-To: <20200807225512.GA28635@alvherre.pgsql>

On 2020-Aug-07, Alvaro Herrera wrote:

> I'm thinking in keeping the sentences that were added in that commit,
> maybe like so:
> 
> >  		 * We only send regular messages to the client for full decoded
> >  		 * transactions, but a synchronous replication and walsender shutdown
> >  		 * possibly are waiting for a later location. So, before sleeping, we
> > +		 * send a ping containing the flush location. A reply from standby is
> > +		 * not needed and would be wasteful most of the time,
> > +		 * but if the receiver is otherwise idle and walreceiver status messages
> > +		 * are enabled, this keepalive will trigger a reply.  Processing the
> > +		 * reply will update these MyWalSnd locations.

After rereading this a few more times, I think it's OK as Noah had it,
so I'll just use his wording.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services





view thread (6+ messages)  latest in thread

Message-ID: <20200807231829.GA3040@alvherre.pgsql>
Permalink:  ../20200807231829.GA3040@alvherre.pgsql/
Also on:    postgresql.org/message-id/20200807231829.GA3040@alvherre.pgsql

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: alvherre@2ndquadrant.com, pgsql-hackers@lists.postgresql.org, noah@leadboat.com
  Subject: Re: walsender waiting_for_ping spuriously set
  In-Reply-To: <20200807231829.GA3040@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox