pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: A micro-optimisation for walkdir()
Date: Fri, 4 Sep 2020 17:52:54 -0400
Message-ID: <20200904215254.GA24145@alvherre.pgsql> (raw)
In-Reply-To: <968019.1599255574@sss.pgh.pa.us>

On 2020-Sep-04, Tom Lane wrote:

> I think that it's standard to test for such symbols by seeing
> if they're defined as macros ... not least because that's the *only*
> way to test their existence in C.

I guess since what we're doing is emulating standard readdir(), that
makes sense.

> Personally, what I'd do is lose the enum and just define the macros
> with simple integer constant values.

WFM.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

view thread (28+ messages)  latest in thread

Message-ID: <20200904215254.GA24145@alvherre.pgsql>
Permalink:  ../20200904215254.GA24145@alvherre.pgsql/
Also on:    postgresql.org/message-id/20200904215254.GA24145@alvherre.pgsql

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: alvherre@2ndquadrant.com, tgl@sss.pgh.pa.us, juanjo.santamaria@gmail.com, thomas.munro@gmail.com
  Subject: Re: A micro-optimisation for walkdir()
  In-Reply-To: <20200904215254.GA24145@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox