From: Noah Misch <noah@leadboat.com>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: tgl@sss.pgh.pa.us
Cc: pryzby@telsasoft.com
Cc: pgsql-hackers@postgresql.org
Subject: Re: v13: CLUSTER segv with wal_level=minimal and parallel index creation
Date: Mon, 7 Sep 2020 19:47:09 -0700
Message-ID: <20200908024709.GA3640955@rfd.leadboat.com> (raw)
In-Reply-To: <20200908.104332.1790214922230554649.horikyota.ntt@gmail.com>
References: <20200907.174036.603784943439284546.horikyota.ntt@gmail.com>
<20200907093255.GA3609623@rfd.leadboat.com>
<20200908.091353.1505164218636547516.horikyota.ntt@gmail.com>
<20200908.104332.1790214922230554649.horikyota.ntt@gmail.com>
On Tue, Sep 08, 2020 at 10:43:32AM +0900, Kyotaro Horiguchi wrote:
> At Tue, 08 Sep 2020 09:13:53 +0900 (JST), Kyotaro Horiguchi <horikyota.ntt@gmail.com> wrote in
> > At Mon, 7 Sep 2020 02:32:55 -0700, Noah Misch <noah@leadboat.com> wrote in
> > > As a PoC, this looks promising. Thanks. Would you add a test case such that
> > > the following demonstrates the bug in the absence of your PoC?
> > >
> > > printf '%s\n%s\n%s\n' 'log_statement = all' 'wal_level = minimal' 'max_wal_senders = 0' >/tmp/minimal.conf
> > > make check TEMP_CONFIG=/tmp/minimal.conf
> >
> > Mmm. I was close to add some tests to 018_wal_optimize.pl but your
> > suggestion seems better. I added several ines to create_index.sql.
> >
> > > Please have the test try both a nailed-and-mapped relation and a "nailed, but
> > > not mapped" relation. I am fairly confident that your PoC fixes the former
> > > case, but the latter may need additional code.
> >
> > Mmm. You're right. I choosed pg_amproc_fam_proc_index as
> > nailed-but-not-mapped index.
>
> I fixed a typo (s/staring/starting/).
At a glance, this looks reasonable. If a closer look doesn't reveal problems,
I'll push this.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: noah@leadboat.com, horikyota.ntt@gmail.com, tgl@sss.pgh.pa.us, pryzby@telsasoft.com
Subject: Re: v13: CLUSTER segv with wal_level=minimal and parallel index creation
In-Reply-To: <20200908024709.GA3640955@rfd.leadboat.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox