pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>
Cc: Julien Rouhaud <rjuju123@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>
Subject: Re: Online checksums verification in the backend
Date: Tue, 8 Sep 2020 12:10:25 +0900
Message-ID: <20200908031025.GD19261@paquier.xyz> (raw)
In-Reply-To: <CA+fd4k4zwWG1AmfLw=EM4GcKQJP5s+_2AyvL_PEoPeSEYGk3xw@mail.gmail.com>
References: <20200403093911.GB1206@nol>
	<20200404090428.GD1206@nol>
	<CA+fd4k7c83ViCvZtochX9msnyigDjcNujphFSXdnd7QOaWXSqA@mail.gmail.com>
	<20200405084355.GF1206@nol>
	<CA+fd4k5VS_QAkdGwU-mwsr1z78XM7egixZ2bDhfeSJm4HCrRGg@mail.gmail.com>
	<20200405094459.GG1206@nol>
	<20200712173403.GI26220@telsasoft.com>
	<20200714090808.GA20780@nol>
	<20200907065858.GC4867@paquier.xyz>
	<CA+fd4k4zwWG1AmfLw=EM4GcKQJP5s+_2AyvL_PEoPeSEYGk3xw@mail.gmail.com>

On Tue, Sep 08, 2020 at 11:36:45AM +0900, Masahiko Sawada wrote:
> On Mon, 7 Sep 2020 at 15:59, Michael Paquier <michael@paquier.xyz> wrote:
>>  In this case it could be better to unregister from the
>> CF app for this entry.
> 
> Well, I sent review comments on this patch and Julien fixed all
> comments. So I’d marked this as Ready for Committer since I didn't
> have further comments at that time, and I was waiting for the
> committer review. I'll look at this patch again but should I remove my
> name from the reviewer after that if no comments?

Ah, sorry, I somewhat missed the previous status of the patch.
Perhaps that's an overdose of CF.  Keeping your name as reviewer is
fine I guess.  I have begun looking at the patch and spotted some
issues, so let's see where we do from here.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (6+ messages)  latest in thread

Message-ID: <20200908031025.GD19261@paquier.xyz>
Permalink:  ../20200908031025.GD19261@paquier.xyz/
Also on:    postgresql.org/message-id/20200908031025.GD19261@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: michael@paquier.xyz, masahiko.sawada@2ndquadrant.com, rjuju123@gmail.com, pryzby@telsasoft.com, robertmhaas@gmail.com, pgsql-hackers@lists.postgresql.org, sawada.mshk@gmail.com
  Subject: Re: Online checksums verification in the backend
  In-Reply-To: <20200908031025.GD19261@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox