From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: k.jamison@fujitsu.com
Cc: pgsql-hackers@postgresql.org
Subject: Re: please update ps display for recovery checkpoint
Date: Wed, 9 Sep 2020 21:00:50 -0500
Message-ID: <20200910020050.GB18552@telsasoft.com> (raw)
In-Reply-To: <20200831065244.GB6555@paquier.xyz>
References: <20200818225238.GP17022@telsasoft.com>
<OSBPR01MB2341D2D3141FB3E4C97A0B4DEF5D0@OSBPR01MB2341.jpnprd01.prod.outlook.com>
<20200820080905.GA10353@paquier.xyz>
<20200831065244.GB6555@paquier.xyz>
On Mon, Aug 31, 2020 at 03:52:44PM +0900, Michael Paquier wrote:
> On Thu, Aug 20, 2020 at 05:09:05PM +0900, Michael Paquier wrote:
> > That could be helpful. Wouldn't it be better to use "end-of-recovery
> > checkpoint" instead? That's the common wording in the code comments.
> >
> > I don't see the point of patch 0002. In the same paragraph, we
> > already know that this applies to any checkpoints.
>
> Thinking more about this.. Could it be better to just add some calls
> to set_ps_display() directly in CreateCheckPoint()? This way, both
> the checkpointer as well as the startup process at the end of recovery
> would benefit from the change.
What would you want the checkpointer's ps to say ?
Normally it just says:
postgres 3468 3151 0 Aug27 ? 00:20:57 postgres: checkpointer
Or do you mean do the same thing as now, but one layer lower, like:
@@ -8728,6 +8725,9 @@ CreateCheckPoint(int flags)
+ if (flags & CHECKPOINT_END_OF_RECOVERY)
+ set_ps_display("recovery checkpoint");
--
Justin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, michael@paquier.xyz, k.jamison@fujitsu.com
Subject: Re: please update ps display for recovery checkpoint
In-Reply-To: <20200910020050.GB18552@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox