pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Georgios Kokolatos <gkokolatos@protonmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: v13: show extended stats target in \d
Date: Fri, 11 Sep 2020 16:26:47 -0300
Message-ID: <20200911192647.GA11512@alvherre.pgsql> (raw)
In-Reply-To: <20200909213627.GW18552@telsasoft.com>

On 2020-Sep-09, Justin Pryzby wrote:

> As for the discussion about a separator, I think maybe a comma is enough.  I
> doubt anyone is going to think that you can get a valid command by prefixing
> this by "CREATE STATISTICS".  Actually, it didn't even occur to me it was valid
> command without the stats target - after all, that's not true of indexes.
> 
> +    "public"."ab1_a_b_stats" (ndistinct, dependencies, mcv) ON a, b FROM ab1, STATISTICS 0
> 
> This revision only shows the stats target in verbose mode (slash dee plus).

I put it back to show in non-verbose mode; after all it's only in the
infrequent case that it's set to anything at all, and also it doesn't
take up another column, as is the case with per-column stats targets.

I changed the separator from comma to semicolon, because it seems a
little less ambiguous.  It's easy to change if people hate that.

... and pushed.  Thanks.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services





view thread (8+ messages)

Message-ID: <20200911192647.GA11512@alvherre.pgsql>
Permalink:  ../20200911192647.GA11512@alvherre.pgsql/
Also on:    postgresql.org/message-id/20200911192647.GA11512@alvherre.pgsql

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: alvherre@2ndquadrant.com, pryzby@telsasoft.com, gkokolatos@protonmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: v13: show extended stats target in \d
  In-Reply-To: <20200911192647.GA11512@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox