pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Bruce Momjian <bruce@momjian.us>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: torikoshia <torikoshia@oss.nttdata.com>
Cc: Atsushi Torikoshi <atorik@gmail.com>
Cc: Tatsuro Yamada <tatsuro.yamada.tf@nttcom.co.jp>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Evgeny Efimkin <efimkin@yandex-team.ru>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view?
Date: Wed, 14 Oct 2020 10:25:23 -0400
Message-ID: <20201014142523.GA9415@momjian.us> (raw)
In-Reply-To: <CAOBaU_bMN1KAjn9Xb8Svhzf4CmiBo0OQioKRtxQs0_g9jFVEUg@mail.gmail.com>
References: <CAOBaU_bt3-CwkAQLu7kUp-Yy7dyjhTntNG7Q30CssJHjaPYKEQ@mail.gmail.com>
	<20201012141445.GA24889@momjian.us>
	<CA+TgmoaK55MiAU1wxizK05ZkxK8KKj83P2WxWCTQ7LLe9P6RCA@mail.gmail.com>
	<3199563.1602527175@sss.pgh.pa.us>
	<20201012195443.GC24889@momjian.us>
	<3250173.1602533250@sss.pgh.pa.us>
	<20201012205340.GD24889@momjian.us>
	<CAOBaU_ZbeQrUESCuLGk3sRZWxXFGaBBO39CxSsFxLeZGicUrJw@mail.gmail.com>
	<20201014140915.GJ24889@momjian.us>
	<CAOBaU_bMN1KAjn9Xb8Svhzf4CmiBo0OQioKRtxQs0_g9jFVEUg@mail.gmail.com>

On Wed, Oct 14, 2020 at 10:21:24PM +0800, Julien Rouhaud wrote:
> On Wed, Oct 14, 2020 at 10:09 PM Bruce Momjian <bruce@momjian.us> wrote:
> > > > OK, I came up with the hash idea only to address one of your concerns
> > > > about mismatched hashes for algorithm improvements/changes.  Seems we
> > > > might as well just document that cross-version hashes are different.
> > >
> > > Ok, so I tried to implement what seems to be the consensus.  First
> > > attached patch moves the current pgss queryid computation in core,
> > > with a new compute_queryid GUC (on/off).  One thing I don't really
> >
> > Why would someone turn compute_queryid off?   Overhead?
> 
> Yes, or possibly to use a different algorithm.

Is there a measureable overhead when this is turned on, since it is off
by default and maybe should default to on.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

  The usefulness of a cup is in its emptiness, Bruce Lee






view thread (222+ messages)  latest in thread

Message-ID: <20201014142523.GA9415@momjian.us>
Permalink:  ../20201014142523.GA9415@momjian.us/
Also on:    postgresql.org/message-id/20201014142523.GA9415@momjian.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: bruce@momjian.us, rjuju123@gmail.com, tgl@sss.pgh.pa.us, robertmhaas@gmail.com, michael@paquier.xyz, alvherre@alvh.no-ip.org, torikoshia@oss.nttdata.com, atorik@gmail.com, tatsuro.yamada.tf@nttcom.co.jp, tomas.vondra@2ndquadrant.com, efimkin@yandex-team.ru, pgsql-hackers@lists.postgresql.org
  Subject: Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view?
  In-Reply-To: <20201014142523.GA9415@momjian.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox