pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers@postgresql.org, Amit Langote <amitlangote09@gmail.com>
Subject: Re: CREATE TABLE .. PARTITION OF fails to preserve tgenabled for inherited row triggers
Date: Tue, 20 Oct 2020 19:26:21 -0300
Message-ID: <20201020222621.GA12830@alvherre.pgsql> (raw)
In-Reply-To: <20201020202001.GA6423@alvherre.pgsql>

On 2020-Oct-20, Alvaro Herrera wrote:

> > diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c
> > index 511f015a86..c8d6f78da2 100644
> > --- a/src/backend/commands/tablecmds.c
> > +++ b/src/backend/commands/tablecmds.c
> > @@ -4321,6 +4321,7 @@ ATPrepCmd(List **wqueue, Relation rel, AlterTableCmd *cmd,
> >  		case AT_DisableTrigAll:
> >  		case AT_DisableTrigUser:
> >  			ATSimplePermissions(rel, ATT_TABLE | ATT_FOREIGN_TABLE);
> > +			ATSimpleRecursion(wqueue, rel, cmd, recurse, lockmode, context);
> >  			pass = AT_PASS_MISC;
> >  			break;
> >  		case AT_EnableRule:		/* ENABLE/DISABLE RULE variants */
> 
> I'll add tests for both cases and push to all branches 11+.

Pushed this part.





view thread (24+ messages)  latest in thread

Message-ID: <20201020222621.GA12830@alvherre.pgsql>
Permalink:  ../20201020222621.GA12830@alvherre.pgsql/
Also on:    postgresql.org/message-id/20201020222621.GA12830@alvherre.pgsql

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: alvherre@alvh.no-ip.org, pryzby@telsasoft.com, amitlangote09@gmail.com
  Subject: Re: CREATE TABLE .. PARTITION OF fails to preserve tgenabled for inherited row triggers
  In-Reply-To: <20201020222621.GA12830@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox