From: Justin Pryzby <pryzby@telsasoft.com>
To: Maksim Kita <kitaetoya@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Allow deleting enum value
Date: Sun, 25 Oct 2020 19:33:04 -0500
Message-ID: <20201026003303.GO9241@telsasoft.com> (raw)
In-Reply-To: <20201007204707.GA210713@yetti>
References: <20201007142656.GA181015@yetti>
<2151250.1602084214@sss.pgh.pa.us>
<2191224.1602086595@sss.pgh.pa.us>
<20201007204707.GA210713@yetti>
On Wed, Oct 07, 2020 at 11:47:07PM +0300, Maksim Kita wrote:
> I like the idea, during prototype I added additional column and modified
> enum_in method. But enum_in is called in contexts that can be important
> for user (like comparisons).
...
> postgres=# ALTER TYPE test_enum DELETE VALUE '2';
> ALTER TYPE
I think it should be called "DROP VALUE"
> postgres=# SELECT * FROM test_table WHERE value = '2';
> ERROR: enum value is dropped test_enum: "2"
> LINE 1: SELECT * FROM test_table WHERE value = '2';
This fails if the value was never added, so why wouldn't it also fail if the
value is added and then removed ?
Maybe you'd want to rename old enum names to something "unlikely", like what we
do for dropped attributes in RemoveAttributeById.
How do you want to handle "adding a value back" ?
I think you should determine/propose/discuss the desired behaviors before
implementing it.
I think you'd also need to update these:
src/bin/pg_dump/pg_dump.c
src/bin/psql/describe.c
src/bin/psql/tab-complete.c
doc/src/sgml/catalogs.sgml
src/test/regress/sql/enum.sql
src/test/regress/expected/enum.out
--
Justin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, kitaetoya@gmail.com, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
Subject: Re: Allow deleting enum value
In-Reply-To: <20201026003303.GO9241@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox