From: Justin Pryzby <pryzby@telsasoft.com>
To: Andrey Borodin <x4mmm@yandex-team.ru>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Darafei Komяpa Praliaskouski <me@komzpa.net>
Cc: Pavel Borisov <pashkin.elfe@gmail.com>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Alexander Korotkov <a.korotkov@postgrespro.ru>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Yet another fast GiST build
Date: Thu, 5 Nov 2020 11:20:30 -0600
Message-ID: <20201105172030.GE22691@telsasoft.com> (raw)
In-Reply-To: <9A94BCF4-5AFE-4F20-90C2-347CF7DD30AF@yandex-team.ru>
References: <4D68C21F-9FB9-41DA-B663-FDFC8D143788@yandex-team.ru>
<4098005f-e4b5-5904-4b33-335dd106c132@iki.fi>
<3520A18A-5C38-4697-A2E3-F3BDE3496CD5@yandex-team.ru>
<FE0D4D5C-A865-4FCC-A5B5-D0296BC99BBE@yandex-team.ru>
<6dda35ae-6760-2349-6589-c6bc87d23d1c@iki.fi>
<D34F656D-FBFA-41DA-9DB8-2C09082BB95C@yandex-team.ru>
<aa095181-1fa1-29ff-f32e-857ba6986d6f@iki.fi>
<82884CC2-4C32-41A1-A28C-D35964B9AC68@yandex-team.ru>
<8da4bfd7-758c-4a20-7760-2841c0725ff8@iki.fi>
<9A94BCF4-5AFE-4F20-90C2-347CF7DD30AF@yandex-team.ru>
On Thu, Nov 05, 2020 at 10:11:52PM +0500, Andrey Borodin wrote:
> To test that functions are actually called for sorting build we should support directive sorting build like "CREATE INDEX ON A USING GIST(B) WITH(sorting=surely,and fail if not)".
Maybe you could add a DEBUG1 message for that, and include that in regression
tests, which would then fail if sorting wasn't used.
Maybe you'd need to make it consistent by setting GUCs like work_mem /
max_parallel_maintenance_workers / ??
Similar to this
postgres=# SET client_min_messages =debug;
postgres=# CREATE INDEX ON A USING GIST(i) WITH(buffering=off);
DEBUG: building index "a_i_idx2" on table "a" serially
CREATE INDEX
> If we have unconditional sorting build and unconditional buffered build we can check opclasses code better.
> The problem is current reloption is called "buffering". It would be strange if we gave this enum possible value like "not buffering, but very much like buffering, just another way".
> How do you think, is it ok to add reloption "buffering=sorting" to enhance tests?
>
> Best regards, Andrey Borodin.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, x4mmm@yandex-team.ru, hlinnaka@iki.fi, tgl@sss.pgh.pa.us, me@komzpa.net, pashkin.elfe@gmail.com, thomas.munro@gmail.com, michael@paquier.xyz, a.korotkov@postgrespro.ru
Subject: Re: Yet another fast GiST build
In-Reply-To: <20201105172030.GE22691@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox