From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: David G. Johnston <david.g.johnston@gmail.com>
Cc: Matthieu Garrigues <matthieu.garrigues@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Dave Cramer <davecramer@postgres.rocks>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Craig Ringer <craig@2ndquadrant.com>
Cc: Vaishnavi Prabakaran <vaishnaviprabakaran@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Daniel Verite <daniel@manitou-mail.org>
Cc: Michael Paquier <michael.paquier@gmail.com>
Subject: Re: PATCH: Batch/pipelining support for libpq
Date: Thu, 12 Nov 2020 10:40:43 -0300
Message-ID: <20201112134043.GA19787@alvherre.pgsql> (raw)
In-Reply-To: <CAKFQuwZTNgNwnHdxQnQnOpKfyX5KW6twgj23ZNUZByDVgmdi7w@mail.gmail.com>
(Adding previous reviewers to CC)
On 2020-Nov-03, David G. Johnston wrote:
> Given the caveats around blocking mode connections why not just require
> non-blocking mode, in a similar fashion to how synchronous functions are
> disallowed?
This is a very good question. Why indeed? Does anybody have a good
answer to this? If not, I propose we just require that non-blocking
mode is in use in order for batch mode to be used.
I've been doing a review pass over this patch and have an updated
version, which I intend to share later today (after I fix what appears
to be a misunderstanding in the "singlerow" test in testlibpqbatch.c)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@alvh.no-ip.org, david.g.johnston@gmail.com, matthieu.garrigues@gmail.com, michael@paquier.xyz, davecramer@postgres.rocks, craig@2ndquadrant.com, vaishnaviprabakaran@gmail.com, andres@anarazel.de, daniel@manitou-mail.org, michael.paquier@gmail.com
Subject: Re: PATCH: Batch/pipelining support for libpq
In-Reply-To: <20201112134043.GA19787@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox