From: David Fetter <david@fetter.org>
To: Stephen Frost <sfrost@snowman.net>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: SELECT INTO deprecation
Date: Wed, 2 Dec 2020 20:57:33 +0100
Message-ID: <20201202195733.GE9795@fetter.org> (raw)
In-Reply-To: <20201202175836.GX16415@tamriel.snowman.net>
References: <96dc0df3-e13a-a85d-d045-d6e2c85218da@enterprisedb.com>
<20201202175836.GX16415@tamriel.snowman.net>
On Wed, Dec 02, 2020 at 12:58:36PM -0500, Stephen Frost wrote:
> Greetings,
>
> * Peter Eisentraut (peter.eisentraut@enterprisedb.com) wrote:
> > While reading about deprecating and removing various things in
> > other threads, I was wondering about how deprecated SELECT INTO
> > is. There are various source code comments about this, but the
> > SELECT INTO reference page only contains soft language like
> > "recommended". I'm proposing the attached patch to stick a more
> > explicit deprecation notice right at the top.
>
> I don't see much value in this. Users already have 5 years to adapt
> their code to new major versions of PG and that strikes me as plenty
> enough time and is why we support multiple major versions of PG for
> so long. Users who keep pace and update for each major version
> aren't likely to have issue making this change since they're already
> used to regularly updating their code for new major versions, while
> others are going to complain no matter when we remove it and will
> ignore any deprecation notices we put out there, so there isn't much
> point in them.
+1 for removing it entirely and including this prominently in the
release notes.
Best,
David.
--
David Fetter <david(at)fetter(dot)org> http://fetter.org/
Phone: +1 415 235 3778
Remember to vote!
Consider donating to Postgres: http://www.postgresql.org/about/donate
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: david@fetter.org, sfrost@snowman.net, peter.eisentraut@enterprisedb.com
Subject: Re: SELECT INTO deprecation
In-Reply-To: <20201202195733.GE9795@fetter.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox