pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feedFrom: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Amit Langote <amitlangote09@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: keisuke kuroda <keisuke.kuroda.3862@gmail.com>
Cc: Tatsuro Yamada <tatsuro.yamada.tf@nttcom.co.jp>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: tatsuhito.kasahara.rd@hco.ntt.co.jp
Subject: Re: Huge memory consumption on partitioned table with FKs
Date: Mon, 7 Dec 2020 11:48:51 -0300
Message-ID: <20201207144851.GA15854@alvherre.pgsql> (raw)
In-Reply-To: <CA+HiwqGKkWYgbpkNkxJOO5Uto7JMs3im-x8K8qmn_f9W+wzesw@mail.gmail.com>
On 2020-Dec-07, Amit Langote wrote:
> On Fri, Dec 4, 2020 at 12:05 PM Kyotaro Horiguchi
> <horikyota.ntt@gmail.com> wrote:
> > > Also, the comment that was in RI_ConstraintInfo now appears in
> > > RI_ConstraintParam, and the new struct (RI_ConstraintInfo) is now
> > > undocumented. What is the relationship between those two structs? I
> > > see that they have pointers to each other, but I think the relationship
> > > should be documented more clearly.
> >
> > I'm not sure the footprint of this patch worth doing but here is a bit
> > more polished version.
>
> I noticed that the foreign_key test fails and it may have to do with
> the fact that a partition's param info remains attached to the
> parent's RI_ConstraintInfo even after it's detached from the parent
> table using DETACH PARTITION.
I think this bit about splitting the struct is a distraction. Let's get
a patch that solves the bug first, and then we can discuss what further
refinements we want to do. I think we should get your patch in
CA+HiwqEOrfN9b=f3sDmySPGc4gO-L_VMFHXLLxVmmdP34e64+w@mail.gmail.com
committed (which I have not read yet.) Do you agree with this plan?
view thread (53+ messages) latest in thread
Message-ID: <20201207144851.GA15854@alvherre.pgsql>
Permalink: ../20201207144851.GA15854@alvherre.pgsql/
Also on: postgresql.org/message-id/20201207144851.GA15854@alvherre.pgsql
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@alvh.no-ip.org, amitlangote09@gmail.com, horikyota.ntt@gmail.com, keisuke.kuroda.3862@gmail.com, tatsuro.yamada.tf@nttcom.co.jp, pgsql-hackers@lists.postgresql.org, tatsuhito.kasahara.rd@hco.ntt.co.jp
Subject: Re: Huge memory consumption on partitioned table with FKs
In-Reply-To: <20201207144851.GA15854@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox