From: Bruce Momjian <bruce@momjian.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Moving other hex functions to /common
Date: Wed, 6 Jan 2021 08:58:23 -0500
Message-ID: <20210106135823.GD32172@momjian.us> (raw)
In-Reply-To: <X/U4NOXIYpe7I2As@paquier.xyz>
References: <20201231003557.GB22199@momjian.us>
<20201231012207.GC22199@momjian.us>
<X+1rVXW19lJM89vx@paquier.xyz>
<20210101200613.GB7432@momjian.us>
<X/ADzYzkP0ExrBq1@paquier.xyz>
<20210105034739.GG7432@momjian.us>
<X/QLn+ejLKP5c1sJ@paquier.xyz>
<20210105172109.GH7432@momjian.us>
<X/U4NOXIYpe7I2As@paquier.xyz>
On Wed, Jan 6, 2021 at 01:10:28PM +0900, Michael Paquier wrote:
> > It was very confusing, and this attached patch fixes all of that. I
> > also added the pg_ prefix you suggrested. If we want to add dstlen to
> > all the functions, we have to do it for all types --- not sure it is
> > worth it, now that things are much clearer.
>
> Overflow protection is very important in my opinion here once we
> expose more those functions. Not touching ECPG at all and not making
> this refactoring pluggable into shared libs is fine by me at the end
> because we don't have a case for libpq yet, but I object to the lack
> of protection against overflows.
Fine. Do you want to add the overflow to the patch I posted, for all
encoding types?
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: bruce@momjian.us, michael@paquier.xyz
Subject: Re: Moving other hex functions to /common
In-Reply-To: <20210106135823.GD32172@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox