From: Justin Pryzby <pryzby@telsasoft.com>
To: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: Josef Šimánek <josef.simanek@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH] Simple progress reporting for COPY command
Date: Wed, 6 Jan 2021 19:17:14 -0600
Message-ID: <20210107011714.GU1849@telsasoft.com> (raw)
In-Reply-To: <1562ca9b-ffb5-e5e9-0399-33db90dbe153@enterprisedb.com>
References: <CAFp7Qwr6_FmRM6pCO0x_a0mymOfX_Gg+FEKet4XaTGSW=LitKQ@mail.gmail.com>
<CALj2ACWAAbVuTvnLAL3B82ZLwyQaF6nteFsABABwxPJqL7gP1A@mail.gmail.com>
<CAFp7QwoWx2voi2j5oaFS4Zk1tVs+OAKb8YqGZTtUVxGqwL8xgA@mail.gmail.com>
<6e7b056e-faff-40f6-730d-3ad6d2d1b5e9@enterprisedb.com>
<CAFp7QwqKp6_iM0R7R+f8pjwWfD+xxgm2NbDLLzj3+2RhMhcJog@mail.gmail.com>
<CAFp7Qwop_j94NaZ4OoOSNpCiLY3m+eq6WO3RmCWCw7Y0tOL_Fw@mail.gmail.com>
<1562ca9b-ffb5-e5e9-0399-33db90dbe153@enterprisedb.com>
On Wed, Jan 06, 2021 at 10:44:49PM +0100, Tomas Vondra wrote:
> On 1/5/21 11:02 AM, Josef Šimánek wrote:
> > I'm attaching the whole patch since commitfest failed to ingest the
> > last incremental on CI.
> >
>
> Yeah, the whole patch needs to be attached for the commitfest tester to work
> correctly - it can't apply pieces from multiple messages, etc.
>
> Anyway, I pushed this last version of patch, after a couple more tweaks,
> mainly to the docs - one place used pg_stat_copy_progress, the section was
> not indexed properly, and so on.
Some more doc fixes.
inline patch 1: doc/src/sgml/monitoring.sgml (+5/-5 lines) download 0001-doc-review-COPY-progress-8a4f618e7ae3cb11b0b37d0f06f.patchFrom 0616f448057905ab9b3218ebddfdd3af52e62bac Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryzbyj@telsasoft.com>
Date: Wed, 6 Jan 2021 19:08:11 -0600
Subject: [PATCH] doc review: COPY progress:
8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
---
doc/src/sgml/monitoring.sgml | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgmlindex 43fe8ae383..3cdb1aff3c 100644--- a/doc/src/sgml/monitoring.sgml+++ b/doc/src/sgml/monitoring.sgml@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
<para>
Whenever <command>COPY</command> is running, the
<structname>pg_stat_progress_copy</structname> view will contain one row
- for each backend that is currently running <command>COPY</command> command.- The table bellow describes the information that will be reported and provide- information how to interpret it.+ for each backend that is currently running a <command>COPY</command> command.+ The table below describes the information that will be reported and provides+ information about how to interpret it.
</para>
<table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
<row>
<entry role="catalog_table_entry"><para role="column_definition">
- <structfield>datid</structfield> <type>text</type>+ <structfield>datid</structfield> <type>oid</type>
</para>
<para>
OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
</para>
<para>
OID of the table on which the <command>COPY</command> command is executed.
- It is set to 0 if <command>SELECT</command> query is provided.+ It is set to 0 if copying from a <command>SELECT</command> query.
</para></entry>
</row>
--
2.17.0
Patches and attachments:download all (2 files, .tar.gz)0001-doc-review-COPY-progress-8a4f618e7ae3cb11b0b37d0f06f.patch (text/x-diff, 1.9K) download
From 0616f448057905ab9b3218ebddfdd3af52e62bac Mon Sep 17 00:00:00 2001
From: Justin Pryzby <pryzbyj@telsasoft.com>
Date: Wed, 6 Jan 2021 19:08:11 -0600
Subject: [PATCH] doc review: COPY progress:
8a4f618e7ae3cb11b0b37d0f06f05c8ff905833f
---
doc/src/sgml/monitoring.sgml | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/doc/src/sgml/monitoring.sgml b/doc/src/sgml/monitoring.sgmlindex 43fe8ae383..3cdb1aff3c 100644--- a/doc/src/sgml/monitoring.sgml+++ b/doc/src/sgml/monitoring.sgml@@ -6414,9 +6414,9 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
<para>
Whenever <command>COPY</command> is running, the
<structname>pg_stat_progress_copy</structname> view will contain one row
- for each backend that is currently running <command>COPY</command> command.- The table bellow describes the information that will be reported and provide- information how to interpret it.+ for each backend that is currently running a <command>COPY</command> command.+ The table below describes the information that will be reported and provides+ information about how to interpret it.
</para>
<table id="pg-stat-progress-copy-view" xreflabel="pg_stat_progress_copy">
@@ -6445,7 +6445,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
<row>
<entry role="catalog_table_entry"><para role="column_definition">
- <structfield>datid</structfield> <type>text</type>+ <structfield>datid</structfield> <type>oid</type>
</para>
<para>
OID of the database to which this backend is connected.
@@ -6467,7 +6467,7 @@ SELECT pg_stat_get_backend_pid(s.backendid) AS pid,
</para>
<para>
OID of the table on which the <command>COPY</command> command is executed.
- It is set to 0 if <command>SELECT</command> query is provided.+ It is set to 0 if copying from a <command>SELECT</command> query.
</para></entry>
</row>
--
2.17.0
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, tomas.vondra@enterprisedb.com, josef.simanek@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: [PATCH] Simple progress reporting for COPY command
In-Reply-To: <20210107011714.GU1849@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox