From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Very misleading documentation for PQreset()
Date: Thu, 21 Jan 2021 22:32:03 -0800
Message-ID: <20210122063203.GA2108099@rfd.leadboat.com> (raw)
In-Reply-To: <1095901.1611268376@sss.pgh.pa.us>
References: <1095901.1611268376@sss.pgh.pa.us>
On Thu, Jan 21, 2021 at 05:32:56PM -0500, Tom Lane wrote:
> I happened to notice that PQreset is documented thus:
>
> This function will close the connection to the server and attempt to
> reestablish a new connection to the same server, using all the same
> parameters previously used.
>
> Since we invented multi-host connection parameters, a reasonable person
> would assume that "to the same server" means we promise to reconnect to
> the same host we selected the first time. There is no such guarantee
> though; the new connection attempt is done just like the first one,
> so it will select the first suitable server in the list.
>
> I think we should just drop that phrase.
I agree that dropping the phrase strictly improves that documentation.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: noah@leadboat.com, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org
Subject: Re: Very misleading documentation for PQreset()
In-Reply-To: <20210122063203.GA2108099@rfd.leadboat.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox