From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: tsunakawa.takay@fujitsu.com <tsunakawa.takay@fujitsu.com>
Cc: iwata.aya@fujitsu.com <iwata.aya@fujitsu.com>
Cc: k.jamison@fujitsu.com <k.jamison@fujitsu.com>
Cc: 'pgsql-hackers@lists.postgresql.org' <pgsql-hackers@lists.postgresql.org>
Subject: Re: libpq debug log
Date: Wed, 3 Feb 2021 11:01:54 -0300
Message-ID: <20210203140154.GA25582@alvherre.pgsql> (raw)
In-Reply-To: <TYAPR01MB2990511185A563A32FB08DFCFEB49@TYAPR01MB2990.jpnprd01.prod.outlook.com>
On 2021-Feb-03, tsunakawa.takay@fujitsu.com wrote:
> (39)
> + of tracing. If (<literal>flags</literal> & <literal>PQTRACE_OUTPUT_TIMESTAMPS</literal>) is
> + true, then timestamp is not printed with each message.
>
> The flag name (OUTPUT) and its description (not printed) doesn't match.
>
> I think you can use less programmatical expression like "If <literal>flags</literal> contains <literal>PQTRACE_OUTPUT_TIMESTAMPS</literal>".
I copied the original style from elsewhere in the manual.
> (41)
> +void
> +PQtraceEx(PGconn *conn, FILE *debug_port, int flags)
> +{
I'm not really sure about making this a separate API call. We could just
make it PQtrace() and increment the libpq so version. I don't think
it's a big deal, frankly.
--
Álvaro Herrera 39°49'30"S 73°17'W
"El conflicto es el camino real hacia la unión"
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@alvh.no-ip.org, tsunakawa.takay@fujitsu.com, iwata.aya@fujitsu.com, k.jamison@fujitsu.com, pgsql-hackers@lists.postgresql.org
Subject: Re: libpq debug log
In-Reply-To: <20210203140154.GA25582@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox