From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Removing support for COPY FROM STDIN in protocol version 2
Date: Thu, 4 Feb 2021 12:25:48 -0300
Message-ID: <20210204152548.GA6658@alvherre.pgsql> (raw)
In-Reply-To: <4095287.1612452060@sss.pgh.pa.us>
On 2021-Feb-04, Tom Lane wrote:
> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> > On 2021-Feb-04, Heikki Linnakangas wrote:
> >> Ok, here we go.
>
> > Are you going to bump the .so version for this? I think that should be
> > done, since some functions disappear and there are struct changes. It
> > is curious, though, to see that exports.txt needs no changes.
>
> Uh, what? There should be no externally visible ABI changes in libpq
> (he says without having read the patch). If there's a need for a library
> major version bump, that'd be sufficient reason not to do this IMO.
Yeah, the changes I was thinking about are all in libpq-int.h so that's
not really a problem. But one enum in libpq-fe.h renumbers values, and
I think it's better to keep the old value labelled as "unused" to avoid
any changes.
--
Álvaro Herrera Valdivia, Chile
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@alvh.no-ip.org, tgl@sss.pgh.pa.us, hlinnaka@iki.fi, michael@paquier.xyz
Subject: Re: Removing support for COPY FROM STDIN in protocol version 2
In-Reply-To: <20210204152548.GA6658@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox