From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: tsunakawa.takay@fujitsu.com <tsunakawa.takay@fujitsu.com>
Cc: iwata.aya@fujitsu.com <iwata.aya@fujitsu.com>
Cc: k.jamison@fujitsu.com <k.jamison@fujitsu.com>
Cc: 'pgsql-hackers@lists.postgresql.org' <pgsql-hackers@lists.postgresql.org>
Subject: Re: libpq debug log
Date: Tue, 9 Feb 2021 07:47:43 -0300
Message-ID: <20210209104743.GA30101@alvherre.pgsql> (raw)
In-Reply-To: <TYAPR01MB2990522654120C921EF76D3DFEB39@TYAPR01MB2990.jpnprd01.prod.outlook.com>
On 2021-Feb-04, tsunakawa.takay@fujitsu.com wrote:
> From: 'Alvaro Herrera' <alvherre@alvh.no-ip.org>
> > > (41)
> > > +void
> > > +PQtraceEx(PGconn *conn, FILE *debug_port, int flags)
> > > +{
> >
> > I'm not really sure about making this a separate API call. We could just
> > make it PQtrace() and increment the libpq so version. I don't think
> > it's a big deal, frankly.
>
> If we change the function signature, we have to bump the so major version and thus soname. The libpq's current so major version is 5, which hasn't been changed since 2006. I'm hesitant to change it for this feature. If you think we can bump the version to 6, I think we can go.
I think it's pretty clear we would not change the so-version for this
feature.
--
Álvaro Herrera 39°49'30"S 73°17'W
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@alvh.no-ip.org, tsunakawa.takay@fujitsu.com, iwata.aya@fujitsu.com, k.jamison@fujitsu.com, pgsql-hackers@lists.postgresql.org
Subject: Re: libpq debug log
In-Reply-To: <20210209104743.GA30101@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox