From: Álvaro Herrera <alvherre@alvh.no-ip.org>
To: Michael Paquier <michael@paquier.xyz>
Cc: Anastasia Lubennikova <a.lubennikova@postgrespro.ru>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: some pointless HeapTupleHeaderIndicatesMovedPartitions calls
Date: Sat, 20 Feb 2021 12:25:58 -0300
Message-ID: <20210220152558.GA31003@alvherre.pgsql> (raw)
In-Reply-To: <YDEHXEKurDw2/wvK@paquier.xyz>
On 2021-Feb-20, Michael Paquier wrote:
> On Sat, Feb 13, 2021 at 10:49:26AM +0900, Michael Paquier wrote:
> > So that's this patch: https://commitfest.postgresql.org/32/2941/.
> > Alvaro is most likely going to take care of that, so let's wait for
> > him.
>
> Hearing nothing, I have looked at this stuff and the simplification
> makes sense. Any comments?
No further comments ... I think the patch is simple enough. Thanks for
looking -- I'll get it pushed on Monday or so.
> I can see that ItemPointerSetMovedPartitions() in itemptr.h is not
> used in the code. Could it be better to change the comment in
> htup_details.h to mention HeapTupleHeaderSetMovedPartitions instead?
> Perhaps not worth bothering, just noticed this on the way.
Hmm. Alternatively, maybe it'd make sense to change
HeapTupleHeaderSetMovedPartition to use ItemPointerSetMovedPartitions
instead of doing ItemPointerSet directly. But that looks mostly
pointless, since the extensibility aspect of this interface has been
superseded by table AM work. I agree we should just remove the macro
and update the comment as you suggest.
--
Álvaro Herrera Valdivia, Chile
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@alvh.no-ip.org, michael@paquier.xyz, a.lubennikova@postgrespro.ru, pgsql-hackers@lists.postgresql.org
Subject: Re: some pointless HeapTupleHeaderIndicatesMovedPartitions calls
In-Reply-To: <20210220152558.GA31003@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox