From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Mahendra Singh Thalor <mahi6run@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Faulty HEAP_XMAX_LOCK_ONLY & HEAP_KEYS_UPDATED hintbit combination
Date: Tue, 23 Feb 2021 17:47:33 -0300
Message-ID: <20210223204733.GA11420@alvherre.pgsql> (raw)
In-Reply-To: <20210204163750.GB22612@nol>
On 2021-Feb-05, Julien Rouhaud wrote:
> Thanks, that's way better, copied in v3.
Thank you, pushed. The code changes are only relevant in master, but I
did back-patch the README.tuplock to all live branches.
> I'm still a bit worried about that description though, as that flag
> isn't consistently set for the FOR UPDATE case. Well, to be more
> precise it's maybe consistently set when the hint bits are computed,
> but in some cases the flag is later cleared, so you won't reliably
> find it in the tuple.
Is that right? I think compute_new_xmax_infomask would set the bit to
infomask2_old_tuple (its last output argument) if it's needed, and so
the bit would find its way to infomask2 eventually. Do you have a case
where it doesn't achieve that?
--
Álvaro Herrera Valdivia, Chile
"E pur si muove" (Galileo Galilei)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@alvh.no-ip.org, rjuju123@gmail.com, mahi6run@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Faulty HEAP_XMAX_LOCK_ONLY & HEAP_KEYS_UPDATED hintbit combination
In-Reply-To: <20210223204733.GA11420@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox