From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Mark Dilger <mark.dilger@enterprisedb.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Andrey M. Borodin <x4mmm@yandex-team.ru>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Amul Sul <sulamul@gmail.com>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: pg_amcheck contrib application
Date: Fri, 12 Mar 2021 22:16:55 -0800
Message-ID: <20210313061655.GC3099026@rfd.leadboat.com> (raw)
In-Reply-To: <2589781.1615615635@sss.pgh.pa.us>
References: <CA+TgmoZ1DP0pkLyuG9y7Jtn2v7N-+dnVxbvBAT__u4-d=UYmbw@mail.gmail.com>
<A80D68F6-E38F-482D-9522-E2FB6AAFE8A1@enterprisedb.com>
<CA+TgmoY3_U=QuQWo4DArBSp+tg2MiCHLwDN_9U2H_iTxj3UcjA@mail.gmail.com>
<9E76E46A-48B2-4869-BD0C-422204C1F767@enterprisedb.com>
<F0A1FD70-A2F4-4528-8A03-8650CAEC0554@enterprisedb.com>
<CA+TgmoYoW2NNQC5qzEfsR9cYWpigqQgP_h5MZCLVt1XRbsXTXQ@mail.gmail.com>
<C37D28BA-3BA3-4776-B812-17F05F3472D8@enterprisedb.com>
<2574324.1615611372@sss.pgh.pa.us>
<2588078.1615613250@sss.pgh.pa.us>
<2589781.1615615635@sss.pgh.pa.us>
On Sat, Mar 13, 2021 at 01:07:15AM -0500, Tom Lane wrote:
> I wrote:
> >> ... btw, prairiedog (which has a rather old Perl) has a
> >> different complaint:
> >> Invalid type 'q' in unpack at t/004_verify_heapam.pl line 104.
>
> > Hmm ... "man perlfunc" on that system quoth
> > q A signed quad (64-bit) value.
> > Q An unsigned quad value.
> > (Quads are available only if your system supports 64-bit
> > integer values _and_ if Perl has been compiled to support those.
> > Causes a fatal error otherwise.)
> > It does not seem unreasonable for us to rely on Perl having that
> > in 2021, so I'll see about upgrading this perl installation.
>
> Hm, wait a minute: hoverfly is showing the same failure, even though
> it claims to be running a 64-bit Perl. Now I'm confused.
On that machine:
[nm@power8-aix 7:0 2021-03-13T06:09:08 ~ 0]$ /usr/bin/perl64 -e 'unpack "q", ""'
[nm@power8-aix 7:0 2021-03-13T06:09:10 ~ 0]$ /usr/bin/perl -e 'unpack "q", ""'
Invalid type 'q' in unpack at -e line 1.
hoverfly does configure with PERL=perl64. /usr/bin/prove is from the 32-bit
Perl, so I suspect the TAP suites get 32-bit Perl that way. (There's no
"prove64".) This test should unpack the field as two 32-bit values, not a
64-bit value, to avoid requiring more from the Perl installation.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: noah@leadboat.com, tgl@sss.pgh.pa.us, mark.dilger@enterprisedb.com, robertmhaas@gmail.com, pg@bowt.ie, thomas.munro@gmail.com, x4mmm@yandex-team.ru, sfrost@snowman.net, michael@paquier.xyz, sulamul@gmail.com, dilipbalaut@gmail.com, andres@anarazel.de
Subject: Re: pg_amcheck contrib application
In-Reply-To: <20210313061655.GC3099026@rfd.leadboat.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox