From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org, Craig Ringer <craig.ringer@enterprisedb.com>
Cc: Matthieu Garrigues <matthieu.garrigues@gmail.com>
Cc: Zhihong Yu <zyu@yugabyte.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Aya Iwata <iwata.aya@jp.fujitsu.com>
Cc: Daniel Vérité <daniel@manitou-mail.org>
Cc: David G. Johnston <david.g.johnston@gmail.com>
Cc: Kirk Jamison <k.jamison@fujitsu.com>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: Nikhil Sontakke <nikhils@2ndquadrant.com>
Cc: Vaishnavi Prabakaran <VaishnaviP@fast.au.fujitsu.com>
Subject: Re: [HACKERS] PATCH: Batch/pipelining support for libpq
Date: Mon, 15 Mar 2021 16:47:25 -0300
Message-ID: <20210315194725.GA10869@alvherre.pgsql> (raw)
In-Reply-To: <20210315190024.GZ29463@telsasoft.com>
On 2021-Mar-15, Justin Pryzby wrote:
> Are you going to update the assertion ?
>
> +#if 0
> Assert((meta == META_NONE && varprefix == NULL) ||
> ((meta == META_GSET || meta == META_ASET) && varprefix != NULL));
> +#endif
Yeah, caught that just after sending. Here's a notpatch.
--
Álvaro Herrera 39°49'30"S 73°17'W
"La virtud es el justo medio entre dos defectos" (Aristóteles)
Attachments:fixassert.notpatch (text/plain, 726B) downloaddiff --git a/src/bin/pgbench/pgbench.c b/src/bin/pgbench/pgbench.cindex ba7b35d83c..e69d43b26b 100644--- a/src/bin/pgbench/pgbench.c+++ b/src/bin/pgbench/pgbench.c@@ -2823,13 +2823,12 @@ readCommandResponse(CState *st, MetaCommand meta, char *varprefix)
int qrynum = 0;
/*
- * varprefix should be set only with \gset or \aset, and SQL commands do- * not need it.+ * varprefix should be set only with \gset or \aset, and \endpipeline and+ * SQL commands do not need it.
*/
-#if 0
Assert((meta == META_NONE && varprefix == NULL) ||
+ ((meta == META_ENDPIPELINE) && varprefix == NULL) ||
((meta == META_GSET || meta == META_ASET) && varprefix != NULL));
-#endif
res = PQgetResult(st->con);
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@2ndquadrant.com, pryzby@telsasoft.com, tgl@sss.pgh.pa.us, craig.ringer@enterprisedb.com, matthieu.garrigues@gmail.com, zyu@yugabyte.com, andres@anarazel.de, iwata.aya@jp.fujitsu.com, daniel@manitou-mail.org, david.g.johnston@gmail.com, k.jamison@fujitsu.com, michael.paquier@gmail.com, nikhils@2ndquadrant.com, VaishnaviP@fast.au.fujitsu.com
Subject: Re: [HACKERS] PATCH: Batch/pipelining support for libpq
In-Reply-To: <20210315194725.GA10869@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox