pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Dmitry Dolgov <9erthalion6@gmail.com>
To: David Steele <david@pgmasters.net>
Cc: Zhihong Yu <zyu@yugabyte.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Greg Stark <stark@mit.edu>
Cc: Pavel Trukhanov <pavel.trukhanov@gmail.com>
Subject: Re: pg_stat_statements and "IN" conditions
Date: Thu, 18 Mar 2021 16:50:02 +0100
Message-ID: <20210318155002.ggrgf2p2mvaodcox@localhost> (raw)
In-Reply-To: <ec47aa60-0a7b-ea3a-222a-5c6a754c2def@pgmasters.net>
References: <CA+q6zcWtUbT_Sxj0V6HY6EZ89uv5wuG5aefpe_9n0Jr3VwntFg@mail.gmail.com>
	<20201118160432.hyko73sqc2bf7nkj@localhost>
	<20201226104635.uvzkftzu72zg5qux@localhost>
	<CALNJ-vQx7u-Nq_wVun72CVrHe4DcGfEurj_ikckJrRy2Pem=JA@mail.gmail.com>
	<20210105125230.etgmgixnn6fmpszl@localhost>
	<CALNJ-vRRrdXu9igzh5PFTBghK5hnQWF6gpntTPo_+Agq_TsT5Q@mail.gmail.com>
	<ec47aa60-0a7b-ea3a-222a-5c6a754c2def@pgmasters.net>

> On Thu, Mar 18, 2021 at 09:38:09AM -0400, David Steele wrote:
> On 1/5/21 10:51 AM, Zhihong Yu wrote:
> >
> > +   int         lastExprLenght = 0;
> >
> > Did you mean to name the variable lastExprLenghth ?
> >
> > w.r.t. extracting to helper method, the second and third
> > if (currentExprIdx == pgss_merge_threshold - 1) blocks are similar.
> > It is up to you whether to create the helper method.
> > I am fine with the current formation.
>
> Dmitry, thoughts on this review?

Oh, right. lastExprLenghth is obviously a typo, and as we agreed that
the helper is not strictly necessary I wanted to wait a bit hoping for
more feedback and eventually to post an accumulated patch. Doesn't make
sense to post another version only to fix one typo :)





view thread (155+ messages)  latest in thread

Message-ID: <20210318155002.ggrgf2p2mvaodcox@localhost>
Permalink:  ../20210318155002.ggrgf2p2mvaodcox@localhost/
Also on:    postgresql.org/message-id/20210318155002.ggrgf2p2mvaodcox@localhost

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: 9erthalion6@gmail.com, david@pgmasters.net, zyu@yugabyte.com, tgl@sss.pgh.pa.us, stark@mit.edu, pavel.trukhanov@gmail.com
  Subject: Re: pg_stat_statements and "IN" conditions
  In-Reply-To: <20210318155002.ggrgf2p2mvaodcox@localhost>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox