From: Justin Pryzby <pryzby@telsasoft.com>
To: Daniil Zakhlystov <usernamedt@yandex-team.ru>
Cc: pgsql-hackers@lists.postgresql.org, Konstantin Knizhnik <knizhnik@garret.ru>
Subject: Re: libpq compression
Date: Thu, 18 Mar 2021 20:02:32 -0500
Message-ID: <20210319010232.GH11765@telsasoft.com> (raw)
In-Reply-To: <161609580905.28624.5304095609680400810.pgcf@coridan.postgresql.org>
References: <aad16e41-b3f9-e89d-fa57-fb4c694bec25@postgrespro.ru>
<a364948a-d93b-fe17-f62d-334f34360daa@postgrespro.ru>
<161609580905.28624.5304095609680400810.pgcf@coridan.postgresql.org>
On Thu, Mar 18, 2021 at 07:30:09PM +0000, Daniil Zakhlystov wrote:
> The new status of this patch is: Ready for Committer
The CF bot is failing , because the last patch sent to the list is from January:
| Latest attachment (libpq-compression-31.patch) at 2021-01-12 14:05:22 from Konstantin Knizhnik ...
The most recent messages have all had links to github repos without patches
attached.
Also, the branches I've looked at on the github repos all have messy history,
and need to be squished into a coherent commit or set of commits.
Would you send a patch to the list with the commits as you propose to merge
them ?
Also, I'm not sure, but I think you may find that the zstd configure.ac should
use pkgconfig. This allowed the CIs to compile these patches. Without
pkg-config, the macos CI couldn't find (at least) LZ4.k
https://commitfest.postgresql.org/32/2813/https://commitfest.postgresql.org/32/3015/
Also, in those patches, we have separate "not for merge" patches which enable
the compression library by default. This allows the CIs to exercise the
feature.
--
Justin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: pryzby@telsasoft.com, usernamedt@yandex-team.ru, knizhnik@garret.ru
Subject: Re: libpq compression
In-Reply-To: <20210319010232.GH11765@telsasoft.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox