pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Justin Pryzby <pryzby@telsasoft.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Alexander Korotkov <a.korotkov@postgrespro.ru>
Cc: David Steele <david@pgmasters.net>
Cc: Ildus Kurbangaliev <i.kurbangaliev@gmail.com>
Cc: Dmitry Dolgov <9erthalion6@gmail.com>
Cc: Andrey Borodin <x4mmm@yandex-team.ru>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: [HACKERS] Custom compression methods
Date: Fri, 19 Mar 2021 12:44:26 -0500
Message-ID: <20210319174425.GM11765@telsasoft.com> (raw)
In-Reply-To: <CA+TgmobuFsxf=nrweN7NYW9VMUV7dX4GYmN966kjeEgXxdxtrg@mail.gmail.com>
References: <CAFiTN-s8SsWs2zCZL3TFxXwi4VE35J=4aKpduKVrTaL+3wnB0A@mail.gmail.com>
	<CA+TgmobRynuR8n18ZyUD4pA-T3tnPk+AME9=bg=jT4s_Uxk22Q@mail.gmail.com>
	<20210315225835.2toe2ceanp7gi6fw@alap3.anarazel.de>
	<CA+Tgmoam+QEwM2=9zfju6Mnc-7499vrtEKX+31w8HwKOOSKvAg@mail.gmail.com>
	<CAFiTN-sBH65e4B5kQB5MT8BQOPajkrKvSdKA-07+ra3f2x4vCA@mail.gmail.com>
	<CAFiTN-tErP5x54pvkZP7yLVJhpNBOZcd5TN_k1BDhjYCA9D0VQ@mail.gmail.com>
	<CA+TgmoYRsapWz2vDSQXFAEL_BAMq1aY37avcq9GAB=SUUvFhaw@mail.gmail.com>
	<CAFiTN-t03PqWCaRW1GoWQa0i2NwYw_p=FDj+Kxu_-rY_viALqw@mail.gmail.com>
	<20210319163511.GL11765@telsasoft.com>
	<CA+TgmobuFsxf=nrweN7NYW9VMUV7dX4GYmN966kjeEgXxdxtrg@mail.gmail.com>

On Fri, Mar 19, 2021 at 01:24:39PM -0400, Robert Haas wrote:
> On Fri, Mar 19, 2021 at 12:35 PM Justin Pryzby <pryzby@telsasoft.com> wrote:
> > I sent offlist a couple of times but notice that the latest patch is missing
> > this bit around AC_CHECK_HEADERS, which apparently can sometimes cause
> > warnings on mac.
> >
> > ac_save_CPPFLAGS=$CPPFLAGS
> > CPPFLAGS="$LZ4_CFLAGS $CPPFLAGS"
> > AC_CHECK_HEADERS(lz4/lz4.h, [],
> >      [AC_CHECK_HEADERS(lz4.h, [], [AC_MSG_ERROR([lz4.h header file is required for LZ4])])])
> > CPPFLAGS=$ac_save_CPPFLAGS
> 
> Hmm, it's working for me on macOS Catalina without this. Why do we
> need it? Can you provide a patch that inserts it in the exact place
> you think it needs to go?

Working with one of Andrey's patches on another thread, he reported offlist
getting this message, resolved by this patch.  Do you see this warning during
./configure ?  The latest CI is of a single patch without the LZ4 stuff, so I
can't check its log.

configure: WARNING: lz4.h: accepted by the compiler, rejected by the preprocessor!                                                                                                                                                 
configure: WARNING: lz4.h: proceeding with the compiler's result                                                                                                                                                                   

-- 
Justin





view thread (430+ messages)  latest in thread

Message-ID: <20210319174425.GM11765@telsasoft.com>
Permalink:  ../20210319174425.GM11765@telsasoft.com/
Also on:    postgresql.org/message-id/20210319174425.GM11765@telsasoft.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: pryzby@telsasoft.com, robertmhaas@gmail.com, dilipbalaut@gmail.com, andres@anarazel.de, tomas.vondra@2ndquadrant.com, a.korotkov@postgrespro.ru, david@pgmasters.net, i.kurbangaliev@gmail.com, 9erthalion6@gmail.com, x4mmm@yandex-team.ru, pgsql-hackers@lists.postgresql.org
  Subject: Re: [HACKERS] Custom compression methods
  In-Reply-To: <20210319174425.GM11765@telsasoft.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox