From: Julien Rouhaud <rjuju123@gmail.com>
To: Bruce Momjian <bruce@momjian.us>
Cc: Hannu Krosing <hannuk@google.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: torikoshia <torikoshia@oss.nttdata.com>
Cc: Atsushi Torikoshi <atorik@gmail.com>
Cc: Tatsuro Yamada <tatsuro.yamada.tf@nttcom.co.jp>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Evgeny Efimkin <efimkin@yandex-team.ru>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view?
Date: Sat, 20 Mar 2021 13:28:33 +0800
Message-ID: <20210320052833.ojsg2azbs5ahnlgi@nol> (raw)
In-Reply-To: <20210320001054.GA7968@momjian.us>
References: <20210317232956.veah6bax3mespdtq@nol>
<20210318134729.GA8529@momjian.us>
<20210318180656.3aat6jkbs7ylcg4k@nol>
<20210318192349.GD3721@momjian.us>
<20210319031650.aqy3ad7fpqsudo3b@nol>
<20210319132906.GG3572@momjian.us>
<20210319142751.vsvsjbp4bsvbh4ek@nol>
<20210319165443.GI3572@momjian.us>
<CAMT0RQR10q0RJNHARtzPr-S_dDAX8us1zcbiQBx8YuuRAeYXAg@mail.gmail.com>
<20210320001054.GA7968@momjian.us>
On Fri, Mar 19, 2021 at 08:10:54PM -0400, Bruce Momjian wrote:
> On Sat, Mar 20, 2021 at 01:03:16AM +0100, Hannu Krosing wrote:
> > It would be really convenient if user-visible serialisations of the query id
> > had something that identifies the computation method.
> >
> > maybe prefix 'N' for internal, 'S' for pg_stat_statements etc.
> >
> > This would immediately show in logs at what point the id calculator was changed
>
> Yeah, but it an integer, and I don't think we want to change that.
Also, with Bruce's approach to ask extensions to error out if they would
overwrite a queryid the only way to change the calculation method is a restart.
So only one source can exist in the system.
Hopefully that's a big enough hammer that administrators will know what method
they're using.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: rjuju123@gmail.com, bruce@momjian.us, hannuk@google.com, robertmhaas@gmail.com, pavel.stehule@gmail.com, tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, michael@paquier.xyz, torikoshia@oss.nttdata.com, atorik@gmail.com, tatsuro.yamada.tf@nttcom.co.jp, tomas.vondra@2ndquadrant.com, efimkin@yandex-team.ru, pgsql-hackers@lists.postgresql.org
Subject: Re: Feature improvement: can we add queryId for pg_catalog.pg_stat_activity view?
In-Reply-To: <20210320052833.ojsg2azbs5ahnlgi@nol>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox