From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Amit Langote <amitlangote09@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: ALTER TABLE .. DETACH PARTITION CONCURRENTLY
Date: Sun, 21 Mar 2021 16:07:12 -0300
Message-ID: <20210321190712.GA8502@alvherre.pgsql> (raw)
In-Reply-To: <20210321182903.GD11765@telsasoft.com>
On 2021-Mar-21, Justin Pryzby wrote:
> On Sun, Mar 21, 2021 at 03:22:00PM -0300, Alvaro Herrera wrote:
>
> > So if we do that on DETACH, what would happen on ATTACH?
>
> Do you mean what happens to the constraint that was already there ?
> Nothing, since it's not ours to mess with. Checking ImpliedBy() rather than
> equal() doesn't change that.
No, I meant what happens regarding checking existing values in the
table: is the table scanned even if the partition constraint is implied
by existing table constraints?
> I proposed this a few years ago for DETACH (without concurrently), specifically
> to avoid the partition scans.
> https://www.postgresql.org/message-id/20180601221428.GU5164@telsasoft.com
> |The docs say: if detaching/re-attach a partition, should first ADD CHECK to
> |avoid a slow ATTACH operation. Perhaps DETACHing a partition could
> |implicitly CREATE a constraint which is usable when reATTACHing?
Well, I agree with you that we should add such a constraint.
--
Álvaro Herrera Valdivia, Chile
"The problem with the future is that it keeps turning into the present"
(Hobbes)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@alvh.no-ip.org, pryzby@telsasoft.com, amitlangote09@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: ALTER TABLE .. DETACH PARTITION CONCURRENTLY
In-Reply-To: <20210321190712.GA8502@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox